You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by "Leif Hedstrom (JIRA)" <ji...@apache.org> on 2010/02/01 21:14:18 UTC
[jira] Created: (TS-128) Eliminate Berkeley DB dependency
Eliminate Berkeley DB dependency
--------------------------------
Key: TS-128
URL: https://issues.apache.org/jira/browse/TS-128
Project: Traffic Server
Issue Type: Improvement
Reporter: Leif Hedstrom
Fix For: 2.0.0a
SimpleDB has a dependency on BDB, we should rewrite this using DBM / NDBM (whatever is available in libc).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-128) Eliminate Berkeley DB dependency
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12829609#action_12829609 ]
Leif Hedstrom commented on TS-128:
----------------------------------
Pain, NDBM on at least RHEL and Fedora is unusable, I think, it's just a wrapper / compatibility mode over BDB. It doesn't even have the appropriate ndbm.h include file. Back to the drawing board.
> Eliminate Berkeley DB dependency
> --------------------------------
>
> Key: TS-128
> URL: https://issues.apache.org/jira/browse/TS-128
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.0.0a
>
>
> SimpleDB has a dependency on BDB, we should rewrite this using DBM / NDBM (whatever is available in libc).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-128) Eliminate Berkeley DB dependency
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom resolved TS-128.
------------------------------
Resolution: Fixed
Fixed.
> Eliminate Berkeley DB dependency
> --------------------------------
>
> Key: TS-128
> URL: https://issues.apache.org/jira/browse/TS-128
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Priority: Blocker
> Fix For: 2.0.0a
>
> Attachments: SimpleDBM.cc, SimpleDBM.h, TS-128-additional.patch, TS-128.patch
>
>
> SimpleDB has a dependency on BDB, we should rewrite this using DBM / NDBM (whatever is available in libc).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-128) Eliminate Berkeley DB dependency
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-128:
-----------------------------
Attachment: TS-128-additional.patch
> Eliminate Berkeley DB dependency
> --------------------------------
>
> Key: TS-128
> URL: https://issues.apache.org/jira/browse/TS-128
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Priority: Blocker
> Fix For: 2.0.0a
>
> Attachments: SimpleDBM.cc, SimpleDBM.h, TS-128-additional.patch, TS-128.patch
>
>
> SimpleDB has a dependency on BDB, we should rewrite this using DBM / NDBM (whatever is available in libc).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-128) Eliminate Berkeley DB dependency
Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12837369#action_12837369 ]
Bryan Call commented on TS-128:
-------------------------------
reviewed: SimpleDBM.diff - looks good
> Eliminate Berkeley DB dependency
> --------------------------------
>
> Key: TS-128
> URL: https://issues.apache.org/jira/browse/TS-128
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Priority: Blocker
> Fix For: 2.0.0a
>
> Attachments: SimpleDBM.cc, SimpleDBM.diff, SimpleDBM.h, TS-128-additional.patch, TS-128.patch
>
>
> SimpleDB has a dependency on BDB, we should rewrite this using DBM / NDBM (whatever is available in libc).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-128) Eliminate Berkeley DB dependency
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-128:
-----------------------------
Attachment: SimpleDBM.h
SimpleDBM.cc
TS-128.patch
Attached is a diff, as well as the entire new SimpleDBM.{cc,h} files (since they are so massively changed. This makes sqlite3 the preferred DB backend, but it can be controlled via ./configure. For example, to get the previous behavior, run configure with
../configure --without-sqlite --with-libdb
(this would be useful for someone like Y!, who wants to preserve the old behavior). Performance wise sqlite doesn't seem quite as fast as libdb, but for the current usage of SimpleDBM, is completely a non-issue. The sqlite3 backend can do about 65k get()'s per second on my box.
Finally, I understand that this is not a particularly OO "approach" to this, but deal for now :).
> Eliminate Berkeley DB dependency
> --------------------------------
>
> Key: TS-128
> URL: https://issues.apache.org/jira/browse/TS-128
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Priority: Blocker
> Fix For: 2.0.0a
>
> Attachments: SimpleDBM.cc, SimpleDBM.h, TS-128.patch
>
>
> SimpleDB has a dependency on BDB, we should rewrite this using DBM / NDBM (whatever is available in libc).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (TS-128) Eliminate Berkeley DB dependency
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom resolved TS-128.
------------------------------
Resolution: Fixed
Closing again, thanks for the input Bryan.
> Eliminate Berkeley DB dependency
> --------------------------------
>
> Key: TS-128
> URL: https://issues.apache.org/jira/browse/TS-128
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Priority: Blocker
> Fix For: 2.0.0a
>
> Attachments: SimpleDBM.cc, SimpleDBM.diff, SimpleDBM.h, TS-128-additional.patch, TS-128.patch
>
>
> SimpleDB has a dependency on BDB, we should rewrite this using DBM / NDBM (whatever is available in libc).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (TS-128) Eliminate Berkeley DB dependency
Posted by "George Paul (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12831227#action_12831227 ]
George Paul commented on TS-128:
--------------------------------
Okay reviewed and tested patch with sqlite3 and bdb on trunk. One minor correction to configure without sqlite3. The configure command should be:
../configure --without-sqlite3 --with-libdb
Looks good to commit for 2.x.
-George
> Eliminate Berkeley DB dependency
> --------------------------------
>
> Key: TS-128
> URL: https://issues.apache.org/jira/browse/TS-128
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Priority: Blocker
> Fix For: 2.0.0a
>
> Attachments: SimpleDBM.cc, SimpleDBM.h, TS-128-additional.patch, TS-128.patch
>
>
> SimpleDB has a dependency on BDB, we should rewrite this using DBM / NDBM (whatever is available in libc).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (TS-128) Eliminate Berkeley DB dependency
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom reassigned TS-128:
--------------------------------
Assignee: Leif Hedstrom
> Eliminate Berkeley DB dependency
> --------------------------------
>
> Key: TS-128
> URL: https://issues.apache.org/jira/browse/TS-128
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Fix For: 2.0.0a
>
>
> SimpleDB has a dependency on BDB, we should rewrite this using DBM / NDBM (whatever is available in libc).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-128) Eliminate Berkeley DB dependency
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-128:
-----------------------------
Priority: Blocker (was: Major)
> Eliminate Berkeley DB dependency
> --------------------------------
>
> Key: TS-128
> URL: https://issues.apache.org/jira/browse/TS-128
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Priority: Blocker
> Fix For: 2.0.0a
>
>
> SimpleDB has a dependency on BDB, we should rewrite this using DBM / NDBM (whatever is available in libc).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Reopened: (TS-128) Eliminate Berkeley DB dependency
Posted by "Bryan Call (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Call reopened TS-128:
---------------------------
on RHEL5:
When using ../configure --without-sqlite3 I get this compilation error:
SimpleDBM.h:140: error: 'DEFAULT_DB_IMPLEMENTATION' was not declared in this scope
When using normal configure I get:
SimpleDBM.cc: In member function 'int SimpleDBM::open(char*, int, void*)':
SimpleDBM.cc:116: error: 'SQLITE_OPEN_READWRITE' was not declared in this scope
SimpleDBM.cc:116: error: 'SQLITE_OPEN_CREATE' was not declared in this scope
SimpleDBM.cc:155: error: 'SQLITE_OPEN_READONLY' was not declared in this scope
SimpleDBM.cc:156: error: 'sqlite3_open_v2' was not declared in this scope
SimpleDBM.cc:165: error: 'sqlite3_prepare_v2' was not declared in this scope
SimpleDBM.cc:172: error: 'sqlite3_prepare_v2' was not declared in this scope
gmake[1]: *** [SimpleDBM.o] Error 1
packages installed:
[bcall@ trafficserver]$ y ls | grep -i sqlite
ports/python-sqlite-1.1.7-1.2.1
ports/sqlite-devel-3.3.6-2
ports/sqlite-3.3.6-2
[bcall@ trafficserver]$ y ls | grep -i db4
ports/db4-devel-4.3.29-9.fc6
ports/db4-4.3.29-9.fc6
> Eliminate Berkeley DB dependency
> --------------------------------
>
> Key: TS-128
> URL: https://issues.apache.org/jira/browse/TS-128
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Priority: Blocker
> Fix For: 2.0.0a
>
> Attachments: SimpleDBM.cc, SimpleDBM.h, TS-128-additional.patch, TS-128.patch
>
>
> SimpleDB has a dependency on BDB, we should rewrite this using DBM / NDBM (whatever is available in libc).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (TS-128) Eliminate Berkeley DB dependency
Posted by "Leif Hedstrom (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-128:
-----------------------------
Attachment: SimpleDBM.diff
Adding some README info, and better checks in configure.ac.
> Eliminate Berkeley DB dependency
> --------------------------------
>
> Key: TS-128
> URL: https://issues.apache.org/jira/browse/TS-128
> Project: Traffic Server
> Issue Type: Improvement
> Reporter: Leif Hedstrom
> Assignee: Leif Hedstrom
> Priority: Blocker
> Fix For: 2.0.0a
>
> Attachments: SimpleDBM.cc, SimpleDBM.diff, SimpleDBM.h, TS-128-additional.patch, TS-128.patch
>
>
> SimpleDB has a dependency on BDB, we should rewrite this using DBM / NDBM (whatever is available in libc).
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.