[jira] [Commented] (ACCUMULO-2489) NPE in split tablet

["Josh Elser (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ACCUMULO-2489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939481#comment-13939481 ] 

Josh Elser commented on ACCUMULO-2489:
--------------------------------------

Reproduced this with a unit test. With the addition of actually implementing {{invalidateCache}} on {{TableConfiguration}}, it's now not threadsafe and you can run into a situation where {{invalidateCache}} is called after {{getTablePropCache}} sets the internal member but before it's returned/used, which causes the NPE [~jvines@gmail.com] reported.

> NPE in split tablet
> -------------------
>
>                 Key: ACCUMULO-2489
>                 URL: https://issues.apache.org/jira/browse/ACCUMULO-2489
>             Project: Accumulo
>          Issue Type: Bug
>          Components: tserver
>    Affects Versions: 1.5.1
>            Reporter: John Vines
>            Assignee: Josh Elser
>            Priority: Critical
>             Fix For: 1.5.2, 1.6.0
>
>
> {code}
> 2014-03-14 23:57:35,534 [thrift.ProcessFunction] ERROR: Internal error processing splitTablet
> java.lang.NullPointerException
>         at org.apache.accumulo.server.conf.TableConfiguration.get(TableConfiguration.java:122)
>         at org.apache.accumulo.server.conf.TableConfiguration.iterator(TableConfiguration.java:139)
>         at org.apache.accumulo.server.conf.TableConfiguration.addObserver(TableConfiguration.java:77)
>         at org.apache.accumulo.server.tabletserver.Tablet.<init>(Tablet.java:1375)
>         at org.apache.accumulo.server.tabletserver.Tablet.<init>(Tablet.java:1154)
>         at org.apache.accumulo.server.tabletserver.Tablet.<init>(Tablet.java:1140)
>         at org.apache.accumulo.server.tabletserver.TabletServer.splitTablet(TabletServer.java:2270)
>         at org.apache.accumulo.server.tabletserver.TabletServer.access$1100(TabletServer.java:231)
>         at org.apache.accumulo.server.tabletserver.TabletServer$ThriftClientHandler.splitTablet(TabletServer.java:1710)
>         at sun.reflect.GeneratedMethodAccessor21.invoke(Unknown Source)
>         at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
>         at java.lang.reflect.Method.invoke(Method.java:597)
>         at org.apache.accumulo.trace.instrument.thrift.TraceWrap$1.invoke(TraceWrap.java:63)
>         at com.sun.proxy.$Proxy2.splitTablet(Unknown Source)
>         at org.apache.accumulo.core.tabletserver.thrift.TabletClientService$Processor$splitTablet.getResult(TabletClientService.java:2177)
>         at org.apache.accumulo.core.tabletserver.thrift.TabletClientService$Processor$splitTablet.getResult(TabletClientService.java:2161)
>         at org.apache.thrift.ProcessFunction.process(ProcessFunction.java:39)
>         at org.apache.thrift.TBaseProcessor.process(TBaseProcessor.java:39)
>         at org.apache.accumulo.server.util.TServerUtils$TimedProcessor.process(TServerUtils.java:155)
>         at org.apache.thrift.server.AbstractNonblockingServer$FrameBuffer.invoke(AbstractNonblockingServer.java:478)
>         at org.apache.accumulo.server.util.TServerUtils$THsHaServer$Invocation.run(TServerUtils.java:207)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:895)
>         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:918)
>         at org.apache.accumulo.trace.instrument.TraceRunnable.run(TraceRunnable.java:47)
>         at org.apache.accumulo.core.util.LoggingRunnable.run(LoggingRunnable.java:34)
>         at java.lang.Thread.run(Thread.java:662){code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)