[jira] [Commented] (ARROW-3991) [gandiva] floating point division shouldn't cause errors

["Pindikura Ravindra (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ARROW-3991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16720010#comment-16720010 ] 

Pindikura Ravindra commented on ARROW-3991:
-------------------------------------------

I checked Oracle, SQLServer and PostgreSQL - all of them throw a divide-by-zero for floating point types too. So, the current behavior of gandiva is already correct.

> [gandiva] floating point division shouldn't cause errors
> --------------------------------------------------------
>
>                 Key: ARROW-3991
>                 URL: https://issues.apache.org/jira/browse/ARROW-3991
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: Gandiva
>            Reporter: Pindikura Ravindra
>            Assignee: Pindikura Ravindra
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> for division, gandiva explicitly checks if the divisor is zero and raises an error.
> This is correct for integer division. For float point divisions, it should just return infinity.
> https://www.gnu.org/software/libc/manual/html_node/Infinity-and-NaN.html#Infinity-and-NaN



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)