You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by xuchuanyin <gi...@git.apache.org> on 2018/09/12 06:05:45 UTC

[GitHub] carbondata pull request #2708: [CARBONDATA-2886] Select Filter Compatibility...

Github user xuchuanyin commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2708#discussion_r216889572
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/scan/executor/impl/AbstractQueryExecutor.java ---
    @@ -383,8 +383,9 @@ private void fillBlockletInfoToTableBlock(List<TableBlockInfo> tableBlockInfos,
               blockletInfo.getBlockletIndex().getMinMaxIndex().getMaxValues());
           // update min and max values in case of old store for measures as min and max is written
           // opposite for measures in old store ( store <= 1.1 version)
    +      byte[][] tempMaxValues = maxValues;
           maxValues = CarbonUtil.updateMinMaxValues(fileFooter, maxValues, minValues, false);
    -      minValues = CarbonUtil.updateMinMaxValues(fileFooter, maxValues, minValues, true);
    +      minValues = CarbonUtil.updateMinMaxValues(fileFooter, tempMaxValues, minValues, true);
    --- End diff --
    
    Is there any difference?


---