You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrii Tkach <at...@hortonworks.com> on 2015/01/14 12:53:03 UTC

Review Request 29882: Merge "Admin > Stack and Upgrade" and "Admin > Versions" pages

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29882/
-----------------------------------------------------------

Review request for Ambari and Andriy Babiichuk.


Bugs: AMBARI-9118
    https://issues.apache.org/jira/browse/AMBARI-9118


Repository: ambari


Description
-------

Merge "Admin > Stack and Upgrade" and "Admin > Versions" pages
Also, make sure that from Admin View > Versions, configure on <clustername> action redirects to the new Stack and Versions > Versions page


Diffs
-----

  ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html c661861 
  ambari-web/app/assets/test/tests.js 203b9c9 
  ambari-web/app/controllers.js b09710f 
  ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 341084b 
  ambari-web/app/controllers/main/admin/stack_versions/repo_version_management_controller.js ef6182c 
  ambari-web/app/controllers/main/admin/stack_versions/repo_versions_controller.js 127930a 
  ambari-web/app/controllers/main/admin/stack_versions/stack_version_details_controller.js 454c99d 
  ambari-web/app/controllers/main/admin/stack_versions/stack_versions_controller.js c61ac03 
  ambari-web/app/controllers/main/service/add_controller.js e97ab09 
  ambari-web/app/messages.js f81e3a5 
  ambari-web/app/routes/main.js 71446bb 
  ambari-web/app/routes/stack_upgrade_routes.js be0f7e5 
  ambari-web/app/styles/application.less 0e13ff4 
  ambari-web/app/templates/main/admin/stack_and_upgrade.hbs ef2f65e 
  ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs PRE-CREATION 
  ambari-web/app/templates/main/admin/stack_upgrade/services.hbs PRE-CREATION 
  ambari-web/app/templates/main/admin/stack_upgrade/upgrade_version_box.hbs PRE-CREATION 
  ambari-web/app/templates/main/admin/stack_upgrade/versions.hbs PRE-CREATION 
  ambari-web/app/views.js 9971914 
  ambari-web/app/views/main/admin.js 2507f98 
  ambari-web/app/views/main/admin/stack_and_upgrade_view.js 3c90e74 
  ambari-web/app/views/main/admin/stack_upgrade/menu_view.js PRE-CREATION 
  ambari-web/app/views/main/admin/stack_upgrade/services_view.js PRE-CREATION 
  ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 20ee0fe 
  ambari-web/app/views/main/admin/stack_upgrade/versions_view.js PRE-CREATION 
  ambari-web/app/views/main/admin/stack_versions/menu.js 1f65b3c 
  ambari-web/app/views/main/admin/stack_versions/operating_systems.js ce47057 
  ambari-web/app/views/main/admin/stack_versions/repo_version_view.js 17a74f2 
  ambari-web/app/views/main/admin/stack_versions/stack_version_details_view.js 9d7ce66 
  ambari-web/app/views/main/admin/stack_versions/stack_version_view.js bee2a1b 
  ambari-web/app/views/main/menu.js 5f318da 
  ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 3fea58c 
  ambari-web/test/controllers/main/admin/stack_version/repo_version_management_controller_test.js 34862bd 
  ambari-web/test/controllers/main/admin/stack_version/repo_versions_controller_test.js 993fa37 
  ambari-web/test/controllers/main/admin/stack_version/stack_version_details_controller_test.js 4e288bf 
  ambari-web/test/controllers/main/admin/stack_version/stack_versions_controller_test.js 4b38e58 
  ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js 8fcb6a6 
  ambari-web/test/views/main/admin/stack_version/stack_version_details_test.js 6798fd1 

Diff: https://reviews.apache.org/r/29882/diff/


Testing
-------


  5190 tests complete (8 seconds)
  60 tests pending


Thanks,

Andrii Tkach


Re: Review Request 29882: Merge "Admin > Stack and Upgrade" and "Admin > Versions" pages

Posted by Aleksandr Kovalenko <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29882/#review68044
-----------------------------------------------------------

Ship it!


Ship It!

- Aleksandr Kovalenko


On Січ. 14, 2015, 11:52 до полудня, Andrii Tkach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29882/
> -----------------------------------------------------------
> 
> (Updated Січ. 14, 2015, 11:52 до полудня)
> 
> 
> Review request for Ambari and Andriy Babiichuk.
> 
> 
> Bugs: AMBARI-9118
>     https://issues.apache.org/jira/browse/AMBARI-9118
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Merge "Admin > Stack and Upgrade" and "Admin > Versions" pages
> Also, make sure that from Admin View > Versions, configure on <clustername> action redirects to the new Stack and Versions > Versions page
> 
> 
> Diffs
> -----
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/list.html c661861 
>   ambari-web/app/assets/test/tests.js 203b9c9 
>   ambari-web/app/controllers.js b09710f 
>   ambari-web/app/controllers/main/admin/stack_and_upgrade_controller.js 341084b 
>   ambari-web/app/controllers/main/admin/stack_versions/repo_version_management_controller.js ef6182c 
>   ambari-web/app/controllers/main/admin/stack_versions/repo_versions_controller.js 127930a 
>   ambari-web/app/controllers/main/admin/stack_versions/stack_version_details_controller.js 454c99d 
>   ambari-web/app/controllers/main/admin/stack_versions/stack_versions_controller.js c61ac03 
>   ambari-web/app/controllers/main/service/add_controller.js e97ab09 
>   ambari-web/app/messages.js f81e3a5 
>   ambari-web/app/routes/main.js 71446bb 
>   ambari-web/app/routes/stack_upgrade_routes.js be0f7e5 
>   ambari-web/app/styles/application.less 0e13ff4 
>   ambari-web/app/templates/main/admin/stack_and_upgrade.hbs ef2f65e 
>   ambari-web/app/templates/main/admin/stack_upgrade/edit_repositories.hbs PRE-CREATION 
>   ambari-web/app/templates/main/admin/stack_upgrade/services.hbs PRE-CREATION 
>   ambari-web/app/templates/main/admin/stack_upgrade/upgrade_version_box.hbs PRE-CREATION 
>   ambari-web/app/templates/main/admin/stack_upgrade/versions.hbs PRE-CREATION 
>   ambari-web/app/views.js 9971914 
>   ambari-web/app/views/main/admin.js 2507f98 
>   ambari-web/app/views/main/admin/stack_and_upgrade_view.js 3c90e74 
>   ambari-web/app/views/main/admin/stack_upgrade/menu_view.js PRE-CREATION 
>   ambari-web/app/views/main/admin/stack_upgrade/services_view.js PRE-CREATION 
>   ambari-web/app/views/main/admin/stack_upgrade/upgrade_version_box_view.js 20ee0fe 
>   ambari-web/app/views/main/admin/stack_upgrade/versions_view.js PRE-CREATION 
>   ambari-web/app/views/main/admin/stack_versions/menu.js 1f65b3c 
>   ambari-web/app/views/main/admin/stack_versions/operating_systems.js ce47057 
>   ambari-web/app/views/main/admin/stack_versions/repo_version_view.js 17a74f2 
>   ambari-web/app/views/main/admin/stack_versions/stack_version_details_view.js 9d7ce66 
>   ambari-web/app/views/main/admin/stack_versions/stack_version_view.js bee2a1b 
>   ambari-web/app/views/main/menu.js 5f318da 
>   ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 3fea58c 
>   ambari-web/test/controllers/main/admin/stack_version/repo_version_management_controller_test.js 34862bd 
>   ambari-web/test/controllers/main/admin/stack_version/repo_versions_controller_test.js 993fa37 
>   ambari-web/test/controllers/main/admin/stack_version/stack_version_details_controller_test.js 4e288bf 
>   ambari-web/test/controllers/main/admin/stack_version/stack_versions_controller_test.js 4b38e58 
>   ambari-web/test/views/main/admin/stack_upgrade/upgrade_version_box_view_test.js 8fcb6a6 
>   ambari-web/test/views/main/admin/stack_version/stack_version_details_test.js 6798fd1 
> 
> Diff: https://reviews.apache.org/r/29882/diff/
> 
> 
> Testing
> -------
> 
> 
>   5190 tests complete (8 seconds)
>   60 tests pending
> 
> 
> Thanks,
> 
> Andrii Tkach
> 
>