You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "fvaleri (via GitHub)" <gi...@apache.org> on 2025/03/13 13:13:01 UTC

[PR] MINOR: Fix upgrade finalization flag [kafka]

fvaleri opened a new pull request, #19198:
URL: https://github.com/apache/kafka/pull/19198

   Fix upgrade finalization flag.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on PR #19198:
URL: https://github.com/apache/kafka/pull/19198#issuecomment-2750383015

   @ijuma @jsancio @chia7712 what we want to do with this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on PR #19198:
URL: https://github.com/apache/kafka/pull/19198#issuecomment-2723838542

   @ijuma the latest update should be better. Let me know. Thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on PR #19198:
URL: https://github.com/apache/kafka/pull/19198#issuecomment-2769783277

   Closing as not needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "dajac (via GitHub)" <gi...@apache.org>.
dajac commented on code in PR #19198:
URL: https://github.com/apache/kafka/pull/19198#discussion_r1993507050


##########
docs/upgrade.html:
##########
@@ -73,7 +73,7 @@ <h5><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading Servers to 4.0.0 from
     </li>
     <li>Once the cluster's behavior and performance have been verified, finalize the upgrade by running
         <code>
-            bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0
+            bin/kafka-features.sh --bootstrap-controller localhost:9092 upgrade --release-version 4.0

Review Comment:
   Is it really needed? I think that `--bootstrap-server` works too.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on code in PR #19198:
URL: https://github.com/apache/kafka/pull/19198#discussion_r1993521469


##########
docs/upgrade.html:
##########
@@ -73,7 +73,7 @@ <h5><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading Servers to 4.0.0 from
     </li>
     <li>Once the cluster's behavior and performance have been verified, finalize the upgrade by running
         <code>
-            bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0
+            bin/kafka-features.sh --bootstrap-controller localhost:9092 upgrade --release-version 4.0

Review Comment:
   I think it depends on the target. Should we clarify this?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19198:
URL: https://github.com/apache/kafka/pull/19198#discussion_r1993523517


##########
docs/upgrade.html:
##########
@@ -73,7 +73,7 @@ <h5><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading Servers to 4.0.0 from
     </li>
     <li>Once the cluster's behavior and performance have been verified, finalize the upgrade by running
         <code>
-            bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0
+            bin/kafka-features.sh --bootstrap-controller localhost:9092 upgrade --release-version 4.0

Review Comment:
   the error looks like you use the controller endpoint with `--bootstrap-server`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "ijuma (via GitHub)" <gi...@apache.org>.
ijuma commented on PR #19198:
URL: https://github.com/apache/kafka/pull/19198#issuecomment-2722566852

   Hmm, having two examples without an explanation of why is confusing. Let's pick the recommended approach and stick with that.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on PR #19198:
URL: https://github.com/apache/kafka/pull/19198#issuecomment-2721368374

   Now mentioning both alternatives. Let me know if it's fine or we don't want to change this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on code in PR #19198:
URL: https://github.com/apache/kafka/pull/19198#discussion_r1999330309


##########
docs/upgrade.html:
##########
@@ -72,10 +72,8 @@ <h5><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading Servers to 4.0.0 from
         brokers will be running the latest version and you can verify that the cluster's behavior and performance meet expectations.
     </li>
     <li>Once the cluster's behavior and performance have been verified, finalize the upgrade by running
-        <code>
-            bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0
-        </code>
-    </li>
+        <code>bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0</code> 
+        (use <code>--bootstrap-controller</code> when running against a controller node).</li>

Review Comment:
   @jsancio thanks for your feedback. Effectively I was laser focused on this use case, and forgot to look at the extended documentation. I noticed that all the other documented commands don't have `--bootstrap-broker` or `--bootstrap-controller`, so I was wondering if that was intentional and we should follow the same approach here, mainly for consistency. Wdyt?
   
   For example, this is what the user gets when running one of the other kafka-features documented commands. Then the user can easily choose the bootstrap option that fits the specific use case.
   
   ```sh
   $ bin/kafka-features.sh upgrade --metadata 3.9
   usage: kafka-features [-h] [--command-config COMMAND_CONFIG] (--bootstrap-server BOOTSTRAP_SERVER | --bootstrap-controller BOOTSTRAP_CONTROLLER) {describe,upgrade,downgrade,disable,version-mapping,feature-dependencies} ...
   kafka-features: error: one of the arguments --bootstrap-server --bootstrap-controller is required
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on code in PR #19198:
URL: https://github.com/apache/kafka/pull/19198#discussion_r1999330309


##########
docs/upgrade.html:
##########
@@ -72,10 +72,8 @@ <h5><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading Servers to 4.0.0 from
         brokers will be running the latest version and you can verify that the cluster's behavior and performance meet expectations.
     </li>
     <li>Once the cluster's behavior and performance have been verified, finalize the upgrade by running
-        <code>
-            bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0
-        </code>
-    </li>
+        <code>bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0</code> 
+        (use <code>--bootstrap-controller</code> when running against a controller node).</li>

Review Comment:
   @jsancio thanks for your feedback. Effectively I was laser focused on this use case, and forgot to look at the extended documentation. I noticed that all the other documented commands don't have `--bootstrap-broker` or `--bootstrap-controller`, so I think we should follow the same approach here, for consistency. Wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on code in PR #19198:
URL: https://github.com/apache/kafka/pull/19198#discussion_r1999330309


##########
docs/upgrade.html:
##########
@@ -72,10 +72,8 @@ <h5><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading Servers to 4.0.0 from
         brokers will be running the latest version and you can verify that the cluster's behavior and performance meet expectations.
     </li>
     <li>Once the cluster's behavior and performance have been verified, finalize the upgrade by running
-        <code>
-            bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0
-        </code>
-    </li>
+        <code>bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0</code> 
+        (use <code>--bootstrap-controller</code> when running against a controller node).</li>

Review Comment:
   @jsancio thanks for your feedback. Effectively I was laser focused on this use case, and forgot to look at the extended documentation. I noticed that all the other documented commands don't have `--bootstrap-broker` or `--bootstrap-controller`, so I was wondering if that was intentional and we should follow the same approach here. Wdyt?
   
   For example, this is what the user gets when running one of the other kafka-features documented commands. Then the user can easily choose the bootstrap option that fits the specific use case.
   
   ```sh
   $ bin/kafka-features.sh upgrade --metadata 3.9
   usage: kafka-features [-h] [--command-config COMMAND_CONFIG] (--bootstrap-server BOOTSTRAP_SERVER | --bootstrap-controller BOOTSTRAP_CONTROLLER) {describe,upgrade,downgrade,disable,version-mapping,feature-dependencies} ...
   kafka-features: error: one of the arguments --bootstrap-server --bootstrap-controller is required
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "FrankYang0529 (via GitHub)" <gi...@apache.org>.
FrankYang0529 commented on code in PR #19198:
URL: https://github.com/apache/kafka/pull/19198#discussion_r1993509997


##########
docs/upgrade.html:
##########
@@ -73,7 +73,7 @@ <h5><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading Servers to 4.0.0 from
     </li>
     <li>Once the cluster's behavior and performance have been verified, finalize the upgrade by running
         <code>
-            bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0
+            bin/kafka-features.sh --bootstrap-controller localhost:9092 upgrade --release-version 4.0

Review Comment:
   If we want to use --bootstrap-controller, it's better to use localhost:9093 as well. In both `server.properties` and `controller.properties`, we use `localhost:9093` for controller.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on code in PR #19198:
URL: https://github.com/apache/kafka/pull/19198#discussion_r1993518917


##########
docs/upgrade.html:
##########
@@ -73,7 +73,7 @@ <h5><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading Servers to 4.0.0 from
     </li>
     <li>Once the cluster's behavior and performance have been verified, finalize the upgrade by running
         <code>
-            bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0
+            bin/kafka-features.sh --bootstrap-controller localhost:9092 upgrade --release-version 4.0

Review Comment:
   I was testing with a controller in this case, and you get the following error:
   
   ```sh
   [2025-03-13 14:23:27,598] WARN [AdminClient clientId=adminclient-1] The remote node is not a BROKER that supports the METADATA api. (org.apache.kafka.clients.admin.internals.AdminMetadataManager)
   org.apache.kafka.common.errors.UnsupportedVersionException: The node does not support METADATA
   [2025-03-13 14:23:27,605] WARN [AdminClient clientId=adminclient-1] The remote node is not a BROKER that supports the METADATA api. (org.apache.kafka.clients.admin.internals.AdminMetadataManager)
   org.apache.kafka.common.errors.UnsupportedVersionException: The node does not support METADATA
   [2025-03-13 14:23:27,606] WARN [AdminClient clientId=adminclient-1] The remote node is not a BROKER that supports the METADATA api. (org.apache.kafka.clients.admin.internals.AdminMetadataManager)
   org.apache.kafka.common.errors.UnsupportedVersionException: The node does not support METADATA
   [2025-03-13 14:23:27,607] WARN [AdminClient clientId=adminclient-1] The remote node is not a BROKER that supports the METADATA api. (org.apache.kafka.clients.admin.internals.AdminMetadataManager)
   org.apache.kafka.common.errors.UnsupportedVersionException: The node does not support METADATA
   Could not upgrade group.version to 1. The node does not support METADATA
   Could not upgrade kraft.version to 1. The node does not support METADATA
   Could not upgrade metadata.version to 25. The node does not support METADATA
   Could not upgrade transaction.version to 2. The node does not support METADATA
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #19198:
URL: https://github.com/apache/kafka/pull/19198#discussion_r1993754860


##########
docs/upgrade.html:
##########
@@ -72,10 +72,8 @@ <h5><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading Servers to 4.0.0 from
         brokers will be running the latest version and you can verify that the cluster's behavior and performance meet expectations.
     </li>
     <li>Once the cluster's behavior and performance have been verified, finalize the upgrade by running
-        <code>
-            bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0
-        </code>
-    </li>
+        <code>bin/kafka-features.sh --bootstrap-controller localhost:9093 upgrade --release-version 4.0</code> 
+        or <code>bin/kafka-features.sh --bootstrap-server localhost:9093 upgrade --release-version 4.0</code>.</li>

Review Comment:
   could you please use 9092 instead for `--bootstrap-server`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri commented on code in PR #19198:
URL: https://github.com/apache/kafka/pull/19198#discussion_r1999330309


##########
docs/upgrade.html:
##########
@@ -72,10 +72,8 @@ <h5><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading Servers to 4.0.0 from
         brokers will be running the latest version and you can verify that the cluster's behavior and performance meet expectations.
     </li>
     <li>Once the cluster's behavior and performance have been verified, finalize the upgrade by running
-        <code>
-            bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0
-        </code>
-    </li>
+        <code>bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0</code> 
+        (use <code>--bootstrap-controller</code> when running against a controller node).</li>

Review Comment:
   @jsancio thanks for your feedback. Effectively I was laser focused on this use case, and forgot to look at the extended documentation. I noticed that all the other documented commands don't have `--bootstrap-broker` or `--bootstrap-controller`, so I think we should follow the same approach here, for consistency. Wdyt?
   
   For example, this is what the user gets when running one of the other kafka-features documented commands. Then the user can easily choose the bootstrap option that fits the specific use case.
   
   ```sh
   $ bin/kafka-features.sh upgrade --metadata 3.9
   usage: kafka-features [-h] [--command-config COMMAND_CONFIG] (--bootstrap-server BOOTSTRAP_SERVER | --bootstrap-controller BOOTSTRAP_CONTROLLER) {describe,upgrade,downgrade,disable,version-mapping,feature-dependencies} ...
   kafka-features: error: one of the arguments --bootstrap-server --bootstrap-controller is required
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "fvaleri (via GitHub)" <gi...@apache.org>.
fvaleri closed pull request #19198: MINOR: Fix upgrade finalization flag
URL: https://github.com/apache/kafka/pull/19198


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] MINOR: Fix upgrade finalization flag [kafka]

Posted by "jsancio (via GitHub)" <gi...@apache.org>.
jsancio commented on code in PR #19198:
URL: https://github.com/apache/kafka/pull/19198#discussion_r1996104170


##########
docs/upgrade.html:
##########
@@ -72,10 +72,8 @@ <h5><a id="upgrade_4_0_0" href="#upgrade_4_0_0">Upgrading Servers to 4.0.0 from
         brokers will be running the latest version and you can verify that the cluster's behavior and performance meet expectations.
     </li>
     <li>Once the cluster's behavior and performance have been verified, finalize the upgrade by running
-        <code>
-            bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0
-        </code>
-    </li>
+        <code>bin/kafka-features.sh --bootstrap-server localhost:9092 upgrade --release-version 4.0</code> 
+        (use <code>--bootstrap-controller</code> when running against a controller node).</li>

Review Comment:
   Did you consider linking to the reference documentation for `kafka-features upgrade` for a detail explanation of all of the command lined options. Otherwise, you end up having to put that disclaimer on every "admin" CLI.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org