[GitHub] [pulsar-helm-chart] sijie commented on a change in pull request #48: Allow Grafana to work with a reverse proxy

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #48:
URL: https://github.com/apache/pulsar-helm-chart/pull/48#discussion_r464652144



##########
File path: charts/pulsar/Chart.yaml
##########
@@ -21,7 +21,7 @@ apiVersion: v1
 appVersion: "2.6.0"
 description: Apache Pulsar Helm chart for Kubernetes
 name: pulsar
-version: 2.6.0
+version: 2.6.1

Review comment:
       Since the chart is for pulsar 2.6.0 and we don't release pulsar 2.6.1 yet, I would suggest not bumping the version here. We can use a naming convention like `<pulsar-version>-<minor-version>` for versioning the helm chart. How does that sound?

##########
File path: charts/pulsar/values.yaml
##########
@@ -856,16 +856,16 @@ grafana:
     targetPort: 3000
     annotations: {}
   plugins: []
+  ## Grafana configMap
+  ## templates/grafana-configmap.yaml
+  ##
+  configData: {}
   ## Grafana ingress
   ## templates/grafana-ingress.yaml
   ##
   ingress:
     enabled: false
-    annotations:

Review comment:
       why did you remove the default values?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org