You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2013/08/01 20:42:04 UTC
Review Request 13194: Updated configure.ac to properly check for Python.h.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13194/
-----------------------------------------------------------
Review request for mesos, Ben Mahler, Brenden Matthews, and Vinod Kone.
Repository: mesos-git
Description
-------
This fix relies on AX_PYTHON_DEVEL from GNU autoconf-archive. It doesn't require 'python-config' like the patch at https://reviews.apache.org/r/11114. It's still a bit kludgy because of the interplay between AM_PATH_PYTHON and AX_PYTHON_DEVEL, but I think it will be reliable.
Diffs
-----
configure.ac 15ada8f84455ed21174f4d831cf3cf1aec3aea73
m4/ax_python_devel.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/13194/diff/
Testing
-------
$ configure PYTHON=python PYTHON_VERSION=2.6
... error
$ configure PYTHON=python2.6
... success
$ configure PYTHON_VERSION=2.6
... success
$ configure
... success
Thanks,
Benjamin Hindman
Re: Review Request 13194: Updated configure.ac to properly check for
Python.h.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13194/#review24476
-----------------------------------------------------------
Ship it!
Ship It!
- Ben Mahler
On Aug. 1, 2013, 6:52 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13194/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2013, 6:52 p.m.)
>
>
> Review request for mesos, Ben Mahler, Brenden Matthews, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This fix relies on AX_PYTHON_DEVEL from GNU autoconf-archive. It doesn't require 'python-config' like the patch at https://reviews.apache.org/r/11114. It's still a bit kludgy because of the interplay between AM_PATH_PYTHON and AX_PYTHON_DEVEL, but I think it will be reliable.
>
>
> Diffs
> -----
>
> configure.ac 15ada8f84455ed21174f4d831cf3cf1aec3aea73
> m4/ax_python_devel.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13194/diff/
>
>
> Testing
> -------
>
> $ configure PYTHON=python PYTHON_VERSION=2.6
> ... error
> $ configure PYTHON=python2.6
> ... success
> $ configure PYTHON_VERSION=2.6
> ... success
> $ configure
> ... success
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 13194: Updated configure.ac to properly check for
Python.h.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13194/
-----------------------------------------------------------
(Updated Aug. 1, 2013, 10:50 p.m.)
Review request for mesos, Ben Mahler, Brenden Matthews, and Vinod Kone.
Changes
-------
Added bug.
Bugs: MESOS-179
https://issues.apache.org/jira/browse/MESOS-179
Repository: mesos-git
Description
-------
This fix relies on AX_PYTHON_DEVEL from GNU autoconf-archive. It doesn't require 'python-config' like the patch at https://reviews.apache.org/r/11114. It's still a bit kludgy because of the interplay between AM_PATH_PYTHON and AX_PYTHON_DEVEL, but I think it will be reliable.
Diffs
-----
configure.ac 15ada8f84455ed21174f4d831cf3cf1aec3aea73
m4/ax_python_devel.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/13194/diff/
Testing
-------
$ configure PYTHON=python PYTHON_VERSION=2.6
... error
$ configure PYTHON=python2.6
... success
$ configure PYTHON_VERSION=2.6
... success
$ configure
... success
Thanks,
Benjamin Hindman
Re: Review Request 13194: Updated configure.ac to properly check for
Python.h.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13194/#review24463
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Aug. 1, 2013, 6:52 p.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13194/
> -----------------------------------------------------------
>
> (Updated Aug. 1, 2013, 6:52 p.m.)
>
>
> Review request for mesos, Ben Mahler, Brenden Matthews, and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> This fix relies on AX_PYTHON_DEVEL from GNU autoconf-archive. It doesn't require 'python-config' like the patch at https://reviews.apache.org/r/11114. It's still a bit kludgy because of the interplay between AM_PATH_PYTHON and AX_PYTHON_DEVEL, but I think it will be reliable.
>
>
> Diffs
> -----
>
> configure.ac 15ada8f84455ed21174f4d831cf3cf1aec3aea73
> m4/ax_python_devel.m4 PRE-CREATION
>
> Diff: https://reviews.apache.org/r/13194/diff/
>
>
> Testing
> -------
>
> $ configure PYTHON=python PYTHON_VERSION=2.6
> ... error
> $ configure PYTHON=python2.6
> ... success
> $ configure PYTHON_VERSION=2.6
> ... success
> $ configure
> ... success
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 13194: Updated configure.ac to properly check for
Python.h.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13194/
-----------------------------------------------------------
(Updated Aug. 1, 2013, 6:52 p.m.)
Review request for mesos, Ben Mahler, Brenden Matthews, and Vinod Kone.
Changes
-------
Consolidated two if checks.
Repository: mesos-git
Description
-------
This fix relies on AX_PYTHON_DEVEL from GNU autoconf-archive. It doesn't require 'python-config' like the patch at https://reviews.apache.org/r/11114. It's still a bit kludgy because of the interplay between AM_PATH_PYTHON and AX_PYTHON_DEVEL, but I think it will be reliable.
Diffs (updated)
-----
configure.ac 15ada8f84455ed21174f4d831cf3cf1aec3aea73
m4/ax_python_devel.m4 PRE-CREATION
Diff: https://reviews.apache.org/r/13194/diff/
Testing
-------
$ configure PYTHON=python PYTHON_VERSION=2.6
... error
$ configure PYTHON=python2.6
... success
$ configure PYTHON_VERSION=2.6
... success
$ configure
... success
Thanks,
Benjamin Hindman