[GitHub] [hudi] pengzhiwei2018 commented on a change in pull request #3393: [HUDI-1842] Spark Sql Support For The Exists Hoodie Table

[GitBox <gi...@apache.org>]

pengzhiwei2018 commented on a change in pull request #3393:
URL: https://github.com/apache/hudi/pull/3393#discussion_r682235533



##########
File path: hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/analysis/HoodieAnalysis.scala
##########
@@ -268,7 +269,25 @@ case class HoodieResolveReferences(sparkSession: SparkSession) extends Rule[Logi
       } else {
         l
       }
-
+    // Fill schema for Create Table without specify schema info
+    case c @ CreateTable(tableDesc, _, _)
+      if isHoodieTable(tableDesc) =>
+        val tablePath = getTableLocation(c.tableDesc, sparkSession)
+          .getOrElse(s"Missing location defined in table ${c.tableDesc.identifier}")

Review comment:
       > is it that for a new table thats getting created, tablePath will be set to "Missing location defined in table ..." ? In other words, if table already existed, tablePath will be set to right value, if not, it will be set to this string.
   > Is my understanding right? If so, why can't we return right away if there table does not exist to maintain the same flow as before for tables that are just getting created.
   
   My mistake! I want to throw an Exception here. Will fix it soon.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org