You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by hv...@apache.org on 2025/06/18 13:49:12 UTC
(spark) branch master updated: [SPARK-52510] Reserve proto numbers for Geospatial types
This is an automated email from the ASF dual-hosted git repository.
hvanhovell pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/spark.git
The following commit(s) were added to refs/heads/master by this push:
new 73ca5e83d20f [SPARK-52510] Reserve proto numbers for Geospatial types
73ca5e83d20f is described below
commit 73ca5e83d20f1f0a7fed3355d85648d98f0864a0
Author: milastdbx <mi...@databricks.com>
AuthorDate: Wed Jun 18 09:48:59 2025 -0400
[SPARK-52510] Reserve proto numbers for Geospatial types
### What changes were proposed in this pull request?
In this PR i propose we reserve numbers in spark connect proto for geospatial types, as per SPIP vote has passed these changes are coming soon and we don't want to clash with other efforts.
### Why are the changes needed?
Geo types need to have their proto file representation, and we need to reserve it
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
This is proto only change
### Was this patch authored or co-authored using generative AI tooling?
No
Closes #51204 from milastdbx/milan-stefanovic_data/reserveNumbersSecondTry.
Authored-by: milastdbx <mi...@databricks.com>
Signed-off-by: Herman van Hovell <he...@databricks.com>
---
python/pyspark/sql/connect/proto/types_pb2.py | 4 ++--
sql/connect/common/src/main/protobuf/spark/connect/types.proto | 3 +++
2 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/python/pyspark/sql/connect/proto/types_pb2.py b/python/pyspark/sql/connect/proto/types_pb2.py
index 2e0ef7048466..e7c0e7726ef1 100644
--- a/python/pyspark/sql/connect/proto/types_pb2.py
+++ b/python/pyspark/sql/connect/proto/types_pb2.py
@@ -35,7 +35,7 @@ _sym_db = _symbol_database.Default()
DESCRIPTOR = _descriptor_pool.Default().AddSerializedFile(
- b"\n\x19spark/connect/types.proto\x12\rspark.connect\"\xf9!\n\x08\x44\x61taType\x12\x32\n\x04null\x18\x01 \x01(\x0b\x32\x1c.spark.connect.DataType.NULLH\x00R\x04null\x12\x38\n\x06\x62inary\x18\x02 \x01(\x0b\x32\x1e.spark.connect.DataType.BinaryH\x00R\x06\x62inary\x12;\n\x07\x62oolean\x18\x03 \x01(\x0b\x32\x1f.spark.connect.DataType.BooleanH\x00R\x07\x62oolean\x12\x32\n\x04\x62yte\x18\x04 \x01(\x0b\x32\x1c.spark.connect.DataType.ByteH\x00R\x04\x62yte\x12\x35\n\x05short\x18\x05 \x01(\x [...]
+ b'\n\x19spark/connect/types.proto\x12\rspark.connect"\x85"\n\x08\x44\x61taType\x12\x32\n\x04null\x18\x01 \x01(\x0b\x32\x1c.spark.connect.DataType.NULLH\x00R\x04null\x12\x38\n\x06\x62inary\x18\x02 \x01(\x0b\x32\x1e.spark.connect.DataType.BinaryH\x00R\x06\x62inary\x12;\n\x07\x62oolean\x18\x03 \x01(\x0b\x32\x1f.spark.connect.DataType.BooleanH\x00R\x07\x62oolean\x12\x32\n\x04\x62yte\x18\x04 \x01(\x0b\x32\x1c.spark.connect.DataType.ByteH\x00R\x04\x62yte\x12\x35\n\x05short\x18\x05 \x01(\x0 [...]
)
_globals = globals()
@@ -47,7 +47,7 @@ if not _descriptor._USE_C_DESCRIPTORS:
"DESCRIPTOR"
]._serialized_options = b"\n\036org.apache.spark.connect.protoP\001Z\022internal/generated"
_globals["_DATATYPE"]._serialized_start = 45
- _globals["_DATATYPE"]._serialized_end = 4390
+ _globals["_DATATYPE"]._serialized_end = 4402
_globals["_DATATYPE_BOOLEAN"]._serialized_start = 1595
_globals["_DATATYPE_BOOLEAN"]._serialized_end = 1662
_globals["_DATATYPE_BYTE"]._serialized_start = 1664
diff --git a/sql/connect/common/src/main/protobuf/spark/connect/types.proto b/sql/connect/common/src/main/protobuf/spark/connect/types.proto
index e1a111e5d691..db82cbe64a9b 100644
--- a/sql/connect/common/src/main/protobuf/spark/connect/types.proto
+++ b/sql/connect/common/src/main/protobuf/spark/connect/types.proto
@@ -71,6 +71,9 @@ message DataType {
Unparsed unparsed = 24;
}
+ // Reserved for geometry and geography types
+ reserved 26, 27;
+
message Boolean {
uint32 type_variation_reference = 1;
}
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org