You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Thomas Mueller (Jira)" <ji...@apache.org> on 2020/09/04 16:00:00 UTC

[jira] [Comment Edited] (SLING-8309) Allow adding CommitHooks and EditorProviders dynamically from bundles

    [ https://issues.apache.org/jira/browse/SLING-8309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17190800#comment-17190800 ] 

Thomas Mueller edited comment on SLING-8309 at 9/4/20, 3:59 PM:
----------------------------------------------------------------

> My use case is a custom variation of the AtomicCounterEditorProvider to increment some counting property values.

[~enorman]  I recommend to provide a patch for Apache Oak. In my view, it doesn't make sense to try to implement something in Sling, if this actually belongs to Apache Oak.


was (Author: tmueller):
> My use case is a custom variation of the AtomicCounterEditorProvider to increment some counting property values.

I recommend to provide a patch for Apache Oak. In my view, it doesn't make sense to try to implement something in Sling, if this actually belongs to Apache Oak.

> Allow adding CommitHooks and EditorProviders dynamically from bundles
> ---------------------------------------------------------------------
>
>                 Key: SLING-8309
>                 URL: https://issues.apache.org/jira/browse/SLING-8309
>             Project: Sling
>          Issue Type: Improvement
>          Components: Oak
>            Reporter: Sergiu Dumitriu
>            Priority: Major
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Currently, {{OakSlingRepositoryManager}} uses a hard-coded list of {{CommitHook}} and {{EditorProvider}} to be used by the Oak repository. This means that other than building a patched version of {{OakSlingRepositoryManager}} there's no way to include a new commit observer. Ideally, a single pseudo-\{{CommitHook}} and pseudo-\{{EditorProvider}} should be handled to Oak, and these should just dynamically aggregate all the {{CommitHook}} and {{EditorProvider}} instances registered in the {{Whiteboard}}.
> All the currently hardcoded components are already available in the whiteboard, so no functionality will be lost, but this change will automatically enable support for {{mix:atomicCounter}} via the {{AtomicCounterEditorProvider}} that's not used at the moment.
> The old behavior should still be available via a new configuration, {{OakSlingRepositoryManagerConfiguration#dynamic_components}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)