[GitHub] [activemq-artemis] gemmellr commented on a change in pull request #3957: Bridge work

[GitBox <gi...@apache.org>]

gemmellr commented on a change in pull request #3957:
URL: https://github.com/apache/activemq-artemis/pull/3957#discussion_r815770092



##########
File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/impl/ClusterConnectionBridge.java
##########
@@ -118,9 +119,20 @@ public ClusterConnectionBridge(final ClusterConnection clusterConnection,
                                   final MessageFlowRecord flowRecord,
                                   final TransportConfiguration connector,
                                   final String storeAndForwardPrefix,
-                                  final StorageManager storageManager) {
-      super(targetLocator, initialConnectAttempts, reconnectAttempts, 0, // reconnectAttemptsOnSameNode means nothing on the clustering bridge since we always try the same
-            retryInterval, retryMultiplier, maxRetryInterval, nodeUUID, name, queue, executor, filterString, forwardingAddress, scheduledExecutor, transformer, useDuplicateDetection, user, password, server, ComponentConfigurationRoutingType.valueOf(ActiveMQDefaultConfiguration.getDefaultBridgeRoutingType()));
+                                  final StorageManager storageManager) throws ActiveMQException {
+      super(targetLocator, new BridgeConfiguration()
+         .setInitialConnectAttempts(initialConnectAttempts)
+         .setReconnectAttempts(reconnectAttempts)
+         .setReconnectAttemptsOnSameNode(0) // reconnectAttemptsOnSameNode means nothing on the clustering bridge since we always try the same
+         .setRetryInterval(retryInterval)
+         .setRetryIntervalMultiplier(retryMultiplier)
+         .setMaxRetryInterval(maxRetryInterval)
+         .setFilterString(filterString.toString())

Review comment:
       There are numerous test failing now due to NPEs from this area. Presumably the older handling ofthe value in the parent dealt with a null while these new bits dont.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@activemq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org