You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (Jira)" <ji...@apache.org> on 2021/03/10 08:08:00 UTC
[jira] [Commented] (THRIFT-5367) Ruby library crashes when using
GC.compact
[ https://issues.apache.org/jira/browse/THRIFT-5367?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17298621#comment-17298621 ]
Jens Geyer commented on THRIFT-5367:
------------------------------------
Just asking:
{code}
- s.add_development_dependency 'bundler', '~> 1.11'
+ s.add_development_dependency 'bundler', '>= 1.0'
{code}
Why is this?
> Ruby library crashes when using GC.compact
> ------------------------------------------
>
> Key: THRIFT-5367
> URL: https://issues.apache.org/jira/browse/THRIFT-5367
> Project: Thrift
> Issue Type: Bug
> Affects Versions: 0.14.1
> Reporter: Stan Hu
> Priority: Major
> Attachments: thrift-ruby-gc.patch
>
>
> Ruby v2.7 introduced support for a compacting garbage collector ([https://bugs.ruby-lang.org/issues/15626)] that can be invoked via `GC.compact`.
>
> The Thrift library does not mark its global constants, so seg faults appear when using `GC.compact`.
>
> The attached patch appears to fix the problem and makes tests pass in Ruby v2.7 and v3.0.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)