You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/05/27 17:13:31 UTC

[GitHub] [samza] prateekm commented on a change in pull request #1368: SAMZA-2532: Refactor MetricsSnapshotReporter and MetricsSnapshotReporterFactory

prateekm commented on a change in pull request #1368:
URL: https://github.com/apache/samza/pull/1368#discussion_r431308428



##########
File path: samza-core/src/main/scala/org/apache/samza/metrics/reporter/MetricsSnapshotReporter.scala
##########
@@ -160,12 +171,9 @@ class MetricsSnapshotReporter(
         }
       }
     }
-
-
     debug("Finished flushing metrics.")
   }
 
-

Review comment:
       Unrelated to PR but useful: Can you change the info log below "Blacklisted metric %s because it matched ..." to either only be logged once with all metrics or logged at debug?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org