You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/03/17 09:39:12 UTC
[GitHub] [incubator-kyuubi] deadwind4 opened a new pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
deadwind4 opened a new pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
Flink SQL Exception message loses line separator.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#issuecomment-1072115025
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2161](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5cd80eb) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/36507f8efcc22e6a2b9128c2f2e265f255104484?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36507f8) will **decrease** coverage by `0.00%`.
> The diff coverage is `80.00%`.
> :exclamation: Current head 5cd80eb differs from pull request most recent head 419b44e. Consider uploading reports for the commit 419b44e to get more accurate results
```diff
@@ Coverage Diff @@
## master #2161 +/- ##
============================================
- Coverage 61.27% 61.27% -0.01%
Complexity 114 114
============================================
Files 320 320
Lines 15501 15505 +4
Branches 1992 1993 +1
============================================
+ Hits 9498 9500 +2
- Misses 5193 5195 +2
Partials 810 810
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/engine/flink/FlinkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvZmxpbmsvRmxpbmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `75.90% <80.00%> (+1.22%)` | :arrow_up: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [36507f8...419b44e](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 edited a comment on pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
pan3793 edited a comment on pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#issuecomment-1070805552
Except for this one, are there other properties that look unreasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
pan3793 commented on pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#issuecomment-1070805552
Except for this one, are there other properties look unreasonable?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#issuecomment-1072115025
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2161](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (419b44e) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/36507f8efcc22e6a2b9128c2f2e265f255104484?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36507f8) will **increase** coverage by `0.16%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head 419b44e differs from pull request most recent head 15e311d. Consider uploading reports for the commit 15e311d to get more accurate results
```diff
@@ Coverage Diff @@
## master #2161 +/- ##
============================================
+ Coverage 61.27% 61.43% +0.16%
- Complexity 114 117 +3
============================================
Files 320 323 +3
Lines 15501 15593 +92
Branches 1992 2001 +9
============================================
+ Hits 9498 9580 +82
- Misses 5193 5195 +2
- Partials 810 818 +8
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/engine/flink/FlinkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvZmxpbmsvRmxpbmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `73.80% <50.00%> (-0.88%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
| [...org/apache/spark/kyuubi/SQLOperationListener.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsva3l1dWJpL1NRTE9wZXJhdGlvbkxpc3RlbmVyLnNjYWxh) | `94.11% <0.00%> (ø)` | |
| [...in/scala/org/apache/spark/kyuubi/StageStatus.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsva3l1dWJpL1N0YWdlU3RhdHVzLnNjYWxh) | `66.66% <0.00%> (ø)` | |
| [.../apache/spark/kyuubi/SparkConsoleProgressBar.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsva3l1dWJpL1NwYXJrQ29uc29sZVByb2dyZXNzQmFyLnNjYWxh) | `94.00% <0.00%> (ø)` | |
| [...pache/kyuubi/engine/hive/operation/GetTables.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1oaXZlLXNxbC1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2hpdmUvb3BlcmF0aW9uL0dldFRhYmxlcy5zY2FsYQ==) | `100.00% <0.00%> (ø)` | |
| [.../kyuubi/credentials/HadoopCredentialsManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jcmVkZW50aWFscy9IYWRvb3BDcmVkZW50aWFsc01hbmFnZXIuc2NhbGE=) | `95.65% <0.00%> (+0.15%)` | :arrow_up: |
| [...i/engine/hive/operation/HiveOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1oaXZlLXNxbC1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2hpdmUvb3BlcmF0aW9uL0hpdmVPcGVyYXRpb25NYW5hZ2VyLnNjYWxh) | `30.00% <0.00%> (+5.86%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [36507f8...15e311d](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] deadwind4 commented on pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
deadwind4 commented on pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#issuecomment-1071989023
I will introduce the white list in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn closed pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
yaooqinn closed pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] deadwind4 edited a comment on pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
deadwind4 edited a comment on pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#issuecomment-1071989023
I have introduced the white list to filter args.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#issuecomment-1072115025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] deadwind4 commented on pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
deadwind4 commented on pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#issuecomment-1071989023
I will introduce the white list in this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#discussion_r829866204
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala
##########
@@ -99,9 +99,11 @@ class FlinkProcessBuilder(
("FLINK_SQL_ENGINE_JAR" -> mainResource.get) +
("FLINK_SQL_ENGINE_DYNAMIC_ARGS" ->
conf.getAll.map { case (k, v) =>
- k match {
- case "line.separator" => ""
- case _ => s"-D$k=$v"
+ if (k.startsWith("kyuubi.") || k.startsWith("flink.")
Review comment:
We can use `conf.getAll.filter{ ... } .map { ... }.mkString(" ")` to make it more readable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#discussion_r829866204
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala
##########
@@ -99,9 +99,11 @@ class FlinkProcessBuilder(
("FLINK_SQL_ENGINE_JAR" -> mainResource.get) +
("FLINK_SQL_ENGINE_DYNAMIC_ARGS" ->
conf.getAll.map { case (k, v) =>
- k match {
- case "line.separator" => ""
- case _ => s"-D$k=$v"
+ if (k.startsWith("kyuubi.") || k.startsWith("flink.")
Review comment:
We can use `conf.getAll.filter { ... } .map { ... }.mkString(" ")` to make it more readable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#issuecomment-1072115025
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2161](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5cd80eb) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/36507f8efcc22e6a2b9128c2f2e265f255104484?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36507f8) will **decrease** coverage by `0.00%`.
> The diff coverage is `80.00%`.
> :exclamation: Current head 5cd80eb differs from pull request most recent head 419b44e. Consider uploading reports for the commit 419b44e to get more accurate results
```diff
@@ Coverage Diff @@
## master #2161 +/- ##
============================================
- Coverage 61.27% 61.27% -0.01%
Complexity 114 114
============================================
Files 320 320
Lines 15501 15505 +4
Branches 1992 1993 +1
============================================
+ Hits 9498 9500 +2
- Misses 5193 5195 +2
Partials 810 810
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/engine/flink/FlinkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvZmxpbmsvRmxpbmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `75.90% <80.00%> (+1.22%)` | :arrow_up: |
| [...rg/apache/kyuubi/engine/trino/TrinoStatement.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS10cmluby1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL3RyaW5vL1RyaW5vU3RhdGVtZW50LnNjYWxh) | `67.46% <0.00%> (-2.41%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [36507f8...419b44e](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#discussion_r829866204
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala
##########
@@ -99,9 +99,11 @@ class FlinkProcessBuilder(
("FLINK_SQL_ENGINE_JAR" -> mainResource.get) +
("FLINK_SQL_ENGINE_DYNAMIC_ARGS" ->
conf.getAll.map { case (k, v) =>
- k match {
- case "line.separator" => ""
- case _ => s"-D$k=$v"
+ if (k.startsWith("kyuubi.") || k.startsWith("flink.")
Review comment:
We can use `conf.getAll.filter{ ... } .map { ... }.mkString(" ")` to make it more readable
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala
##########
@@ -99,9 +99,11 @@ class FlinkProcessBuilder(
("FLINK_SQL_ENGINE_JAR" -> mainResource.get) +
("FLINK_SQL_ENGINE_DYNAMIC_ARGS" ->
conf.getAll.map { case (k, v) =>
- k match {
- case "line.separator" => ""
- case _ => s"-D$k=$v"
+ if (k.startsWith("kyuubi.") || k.startsWith("flink.")
Review comment:
We can use `conf.getAll.filter { ... } .map { ... }.mkString(" ")` to make it more readable
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala
##########
@@ -99,9 +99,11 @@ class FlinkProcessBuilder(
("FLINK_SQL_ENGINE_JAR" -> mainResource.get) +
("FLINK_SQL_ENGINE_DYNAMIC_ARGS" ->
conf.getAll.map { case (k, v) =>
- k match {
- case "line.separator" => ""
- case _ => s"-D$k=$v"
+ if (k.startsWith("kyuubi.") || k.startsWith("flink.")
Review comment:
We can use `conf.getAll.filter { ... }.map { ... }.mkString(" ")` to make it more readable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#discussion_r829866204
##########
File path: kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala
##########
@@ -99,9 +99,11 @@ class FlinkProcessBuilder(
("FLINK_SQL_ENGINE_JAR" -> mainResource.get) +
("FLINK_SQL_ENGINE_DYNAMIC_ARGS" ->
conf.getAll.map { case (k, v) =>
- k match {
- case "line.separator" => ""
- case _ => s"-D$k=$v"
+ if (k.startsWith("kyuubi.") || k.startsWith("flink.")
Review comment:
We can use `conf.getAll.filter { ... }.map { ... }.mkString(" ")` to make it more readable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#issuecomment-1072115025
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2161](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (15e311d) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/36507f8efcc22e6a2b9128c2f2e265f255104484?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (36507f8) will **increase** coverage by `0.15%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## master #2161 +/- ##
============================================
+ Coverage 61.27% 61.43% +0.15%
- Complexity 114 117 +3
============================================
Files 320 323 +3
Lines 15501 15591 +90
Branches 1992 2001 +9
============================================
+ Hits 9498 9578 +80
Misses 5193 5193
- Partials 810 820 +10
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/engine/flink/FlinkProcessBuilder.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9lbmdpbmUvZmxpbmsvRmxpbmtQcm9jZXNzQnVpbGRlci5zY2FsYQ==) | `71.95% <0.00%> (-2.74%)` | :arrow_down: |
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
| [...mon/src/main/scala/org/apache/kyuubi/Logging.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLWNvbW1vbi9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9Mb2dnaW5nLnNjYWxh) | `39.72% <0.00%> (-1.37%)` | :arrow_down: |
| [...org/apache/spark/kyuubi/SQLOperationListener.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsva3l1dWJpL1NRTE9wZXJhdGlvbkxpc3RlbmVyLnNjYWxh) | `94.11% <0.00%> (ø)` | |
| [...pache/kyuubi/engine/hive/operation/GetTables.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1oaXZlLXNxbC1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2hpdmUvb3BlcmF0aW9uL0dldFRhYmxlcy5zY2FsYQ==) | `100.00% <0.00%> (ø)` | |
| [.../apache/spark/kyuubi/SparkConsoleProgressBar.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsva3l1dWJpL1NwYXJrQ29uc29sZVByb2dyZXNzQmFyLnNjYWxh) | `94.00% <0.00%> (ø)` | |
| [...in/scala/org/apache/spark/kyuubi/StageStatus.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1zcGFyay1zcWwtZW5naW5lL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvc3Bhcmsva3l1dWJpL1N0YWdlU3RhdHVzLnNjYWxh) | `66.66% <0.00%> (ø)` | |
| [.../kyuubi/credentials/HadoopCredentialsManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9jcmVkZW50aWFscy9IYWRvb3BDcmVkZW50aWFsc01hbmFnZXIuc2NhbGE=) | `95.65% <0.00%> (+0.15%)` | :arrow_up: |
| [...i/engine/hive/operation/HiveOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXh0ZXJuYWxzL2t5dXViaS1oaXZlLXNxbC1lbmdpbmUvc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9reXV1YmkvZW5naW5lL2hpdmUvb3BlcmF0aW9uL0hpdmVPcGVyYXRpb25NYW5hZ2VyLnNjYWxh) | `30.00% <0.00%> (+5.86%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [36507f8...15e311d](https://codecov.io/gh/apache/incubator-kyuubi/pull/2161?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] yaooqinn commented on pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#issuecomment-1072956490
thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [incubator-kyuubi] deadwind4 edited a comment on pull request #2161: [KYUUBI #2159][FLINK] Prevent loss of exception message line separator
Posted by GitBox <gi...@apache.org>.
deadwind4 edited a comment on pull request #2161:
URL: https://github.com/apache/incubator-kyuubi/pull/2161#issuecomment-1071989023
I have introduced the white list to filter args.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org