[GitHub] [incubator-druid] jihoonson commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #7185: Avoid many unnecessary materializations of collections of 'all segments in cluster' cardinality
URL: https://github.com/apache/incubator-druid/pull/7185#discussion_r264383266
 
 

 ##########
 File path: server/src/main/java/org/apache/druid/metadata/MetadataSegmentManager.java
 ##########
 @@ -59,6 +60,8 @@
 
   Collection<ImmutableDruidDataSource> getDataSources();
 
+  Iterable<DataSegment> iterateAllSegments();
 
 Review comment:
   I also feel this would iterate itself rather than returning an iterable. Even if the iteration can be not cheap, I think it should be fine to call `getIterable` because returning an iterable is cheap.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org