You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/16 21:01:24 UTC

[GitHub] [arrow-datafusion] alamb commented on a change in pull request #891: add cross join support to ballista

alamb commented on a change in pull request #891:
URL: https://github.com/apache/arrow-datafusion/pull/891#discussion_r689856694



##########
File path: ballista/rust/core/proto/ballista.proto
##########
@@ -249,9 +249,10 @@ message LogicalPlanNode {
     RepartitionNode repartition = 9;
     EmptyRelationNode empty_relation = 10;
     CreateExternalTableNode create_external_table = 11;
-    AnalyzeNode analyze = 14;
     ExplainNode explain = 12;
     WindowNode window = 13;
+    AnalyzeNode analyze = 14;

Review comment:
       I don't have a strong preference. `rust` will tell us when the cases are missing so the order in which they are defined is not all that critical in my opinion




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org