[jira] [Created] (TRINIDAD-2478) FileSystemStyleCache file modification checking not working

["Andy Schwartz (JIRA)" <de...@myfaces.apache.org>]

Andy Schwartz created TRINIDAD-2478:
---------------------------------------

             Summary: FileSystemStyleCache file modification checking not working
                 Key: TRINIDAD-2478
                 URL: https://issues.apache.org/jira/browse/TRINIDAD-2478
             Project: MyFaces Trinidad
          Issue Type: Bug
    Affects Versions: 2.1.1-core
            Reporter: Andy Schwartz
            Assignee: Andy Schwartz
            Priority: Trivial


I introduced a minor regression in my fix for Trinidad-2468.  

The bug is here:

>     Future<Entry> f = cache.get(key);
>     Entry entry = _getEntryFromFuture(context, document, cache, key, f);
>     if ((entry != null) && !_validateEntry(entry, checkModified))
>     {
>       // atomically remove the key from the cache if it currently points to the entry
>       cache.remove(key, entry);
>       entry = null;
>     }

The cache.remove() call should be removing the Future, not the Entry.  So:

>       cache.remove(key, entry);

Should be:

>       cache.remove(key, f);

The impact of this bug is that, when org.apache.myfaces.trinidad.CHECK_FILE_MODIFICATION is enabled, we won't actually clear out our in-memory cache, and won't re-generate the .css files, if we detect that the generated .css files have been blown away out from under us.  A server bounce is now required.



--
This message was sent by Atlassian JIRA
(v6.2#6252)