You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/24 09:32:32 UTC
[GitHub] [incubator-seatunnel] simon824 opened a new pull request #1152: [SeaTunnel #990][FOLLOWUP] Optimize clickhouse connector checkConfig
simon824 opened a new pull request #1152:
URL: https://github.com/apache/incubator-seatunnel/pull/1152
## Purpose of this pull request
Optimize clickhouse connector checkConfig
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in you PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/developement/NewLicenseGuide.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #1152: [Improve] [config] Optimize clickhouse connector checkConfig
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #1152:
URL: https://github.com/apache/incubator-seatunnel/pull/1152
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 edited a comment on pull request #1152: [SeaTunnel #990][FOLLOWUP] Optimize clickhouse connector checkConfig
Posted by GitBox <gi...@apache.org>.
leo65535 edited a comment on pull request #1152:
URL: https://github.com/apache/incubator-seatunnel/pull/1152#issuecomment-1019899983
hi @simon824, you can create an umbrella issue, so we can know more about this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] simon824 commented on pull request #1152: [SeaTunnel #990][FOLLOWUP] Optimize clickhouse connector checkConfig
Posted by GitBox <gi...@apache.org>.
simon824 commented on pull request #1152:
URL: https://github.com/apache/incubator-seatunnel/pull/1152#issuecomment-1019988473
> hi @simon824, you can create an umbrella issue, so we can know more about this patch.
#1153 cc @leo65535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on pull request #1152: [SeaTunnel #990][FOLLOWUP] Optimize clickhouse connector checkConfig
Posted by GitBox <gi...@apache.org>.
leo65535 commented on pull request #1152:
URL: https://github.com/apache/incubator-seatunnel/pull/1152#issuecomment-1019899983
hi @simon824, you can create an umbrella issus, so we can know more about this patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] simon824 commented on pull request #1152: [Feature] [config] Optimize clickhouse connector checkConfig
Posted by GitBox <gi...@apache.org>.
simon824 commented on pull request #1152:
URL: https://github.com/apache/incubator-seatunnel/pull/1152#issuecomment-1042650885
@leo65535 @CalvinKirs PTAL, thx. This pr aim to optimized check config logic by `checkConfigUtil`, reduce redundant code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org