You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by "Bryce Curtis (JIRA)" <ji...@apache.org> on 2012/10/25 22:21:14 UTC

[jira] [Created] (CB-1747) Change signature back to public void init(CordovaWebView, CordovaWebViewClient, CordovaChromeClient)

Bryce Curtis created CB-1747:
--------------------------------

             Summary: Change signature back to public void init(CordovaWebView, CordovaWebViewClient, CordovaChromeClient)
                 Key: CB-1747
                 URL: https://issues.apache.org/jira/browse/CB-1747
             Project: Apache Cordova
          Issue Type: Bug
          Components: Android
    Affects Versions: 2.2.0
            Reporter: Bryce Curtis
            Assignee: Joe Bowser
             Fix For: 2.2.0


The commit

https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commitdiff;h=6aafd6dc3aec1ed1fe1d7a3e08d73deedddbc3a3

changes the signature of a public method

-    public void init(CordovaWebView webView, CordovaWebViewClient
webViewClient, CordovaChromeClient webChromeClient) {
+    public void init(CordovaWebView webView, CordovaChromeClient
webChromeClient) {

which breaks any app that extends DroidGap & calls init with their own
view and chrome clients.


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

[jira] [Resolved] (CB-1747) Change signature back to public void init(CordovaWebView, CordovaWebViewClient, CordovaChromeClient)

Posted by "Joe Bowser (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CB-1747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Bowser resolved CB-1747.
----------------------------

    Resolution: Fixed

This commit fixes it: https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commit;h=7f4ee7b20a259143a53d335d3a5482f7acfa8073
                
> Change signature back to public void init(CordovaWebView, CordovaWebViewClient, CordovaChromeClient)
> ----------------------------------------------------------------------------------------------------
>
>                 Key: CB-1747
>                 URL: https://issues.apache.org/jira/browse/CB-1747
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 2.2.0
>            Reporter: Bryce Curtis
>            Assignee: Joe Bowser
>             Fix For: 2.2.0
>
>
> The commit
> https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=commitdiff;h=6aafd6dc3aec1ed1fe1d7a3e08d73deedddbc3a3
> changes the signature of a public method
> -    public void init(CordovaWebView webView, CordovaWebViewClient
> webViewClient, CordovaChromeClient webChromeClient) {
> +    public void init(CordovaWebView webView, CordovaChromeClient
> webChromeClient) {
> which breaks any app that extends DroidGap & calls init with their own
> view and chrome clients.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira