You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/11/15 20:58:44 UTC
[GitHub] [pinot] dang-stripe opened a new issue #7770: Make broker segment unavailable exception configurable on Pinot Java client
dang-stripe opened a new issue #7770:
URL: https://github.com/apache/pinot/issues/7770
We're currently using the pinot java client for queries. With the introduction of https://github.com/apache/pinot/pull/7397, we're seeing more query exceptions since the java client currently raises an exception when there are any exceptions in the response: https://github.com/apache/pinot/blob/6611ff82f46ea837e6bd8edefd46ccc16d4e2002/pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/Connection.java#L126-L128
Can we make this behavior configurable on the client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 commented on issue #7770: Make broker segment unavailable exception configurable on Pinot Java client
Posted by GitBox <gi...@apache.org>.
xiangfu0 commented on issue #7770:
URL: https://github.com/apache/pinot/issues/7770#issuecomment-971922682
Agreed, here we should provide some options for client side to config when to fail and how the exceptions are thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #7770: Make broker segment unavailable exception configurable on Pinot Java client
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7770:
URL: https://github.com/apache/pinot/issues/7770#issuecomment-969371528
@xiangfu0 ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on issue #7770: Make broker segment unavailable exception configurable on Pinot Java client
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on issue #7770:
URL: https://github.com/apache/pinot/issues/7770#issuecomment-969324728
2 options I can think of:
1. Add a flag to not fail the query, but log the exceptions as response metadata
2. Configure certain error codes to be ignored
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] xiangfu0 closed issue #7770: Make broker segment unavailable exception configurable on Pinot Java client
Posted by GitBox <gi...@apache.org>.
xiangfu0 closed issue #7770:
URL: https://github.com/apache/pinot/issues/7770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] dang-stripe commented on issue #7770: Make broker segment unavailable exception configurable on Pinot Java client
Posted by GitBox <gi...@apache.org>.
dang-stripe commented on issue #7770:
URL: https://github.com/apache/pinot/issues/7770#issuecomment-989376722
Thanks for addressing this! The fix is much appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] dang-stripe edited a comment on issue #7770: Make broker segment unavailable exception configurable on Pinot Java client
Posted by GitBox <gi...@apache.org>.
dang-stripe edited a comment on issue #7770:
URL: https://github.com/apache/pinot/issues/7770#issuecomment-970960488
@Jackie-Jiang @xiangfu0 I think we have a preference for option 1 since it'll give us more control over what consistency guarantees we need which vary per query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] dang-stripe commented on issue #7770: Make broker segment unavailable exception configurable on Pinot Java client
Posted by GitBox <gi...@apache.org>.
dang-stripe commented on issue #7770:
URL: https://github.com/apache/pinot/issues/7770#issuecomment-970960488
@Jackie-Jiang @xiangfu0 I think we have a preference for option 1 since it'll give us more control over what consistency guarantees we need which may very per query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org