You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Aman-Mittal (via GitHub)" <gi...@apache.org> on 2026/10/10 15:37:17 UTC

[PR] fix(frontend): send the withdraw command the BFF accepts [fineract-consumer-facing]

Aman-Mittal opened a new pull request, #191:
URL: https://github.com/apache/fineract-consumer-facing/pull/191

   Fixes #190.
   
   The app sent `command=withdraw` to `POST /api/v1/loans/{loanId}`. The BFF only accepts `command=withdrawnByApplicant` there, so withdrawing a draft loan application always failed with 400. This PR changes `WITHDRAW_COMMAND` in `bff-loan.api.ts` to `withdrawnByApplicant`, with a comment pointing at the BFF constant it must match. `loans.store.spec.ts` pinned the wrong value and now pins this one.
   
   ## Verification
   - `npm test` passes 144/144; lint and format pass.
   - Against the real stack (`docker-compose.e2e.yml`), with the full-stack Playwright journey from the e2e PR:
     - before this change: the withdraw returns 400 and the draft stays;
     - after it: the withdraw succeeds and the draft card disappears.
   
   Calling Fineract directly with `withdrawnByApplicant` also succeeds, which confirms the BFF is passing the right command upstream.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] fix(frontend): send the withdraw command the BFF accepts [fineract-consumer-facing]

Posted by "Aman-Mittal (via GitHub)" <gi...@apache.org>.
Aman-Mittal merged PR #191:
URL: https://github.com/apache/fineract-consumer-facing/pull/191


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org