[jira] [Commented] (SOLR-8565) add & use CommonParams.(ROWS|START)_DEFAULT constant

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15108462#comment-15108462 ] 

ASF subversion and git services commented on SOLR-8565:
-------------------------------------------------------

Commit 1725708 from [~cpoerschke] in branch 'dev/trunk'
[ https://svn.apache.org/r1725708 ]

SOLR-8565: add & use CommonParams.(ROWS|START)_DEFAULT constants, add CommonParamsTest

> add & use CommonParams.(ROWS|START)_DEFAULT constant
> ----------------------------------------------------
>
>                 Key: SOLR-8565
>                 URL: https://issues.apache.org/jira/browse/SOLR-8565
>             Project: Solr
>          Issue Type: Task
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>            Priority: Minor
>         Attachments: SOLR-8565.patch
>
>
> * add & use {{CommonParams.ROWS_DEFAULT}} constant (instead of 10)
> * add & use {{CommonParams.START_DEFAULT}} (instead of 0)
> * add {{CommonParamsTest}} test (initially only with {{test(Start|Rows)\[Default\]}} methods)
> This will make it easier to understand what value is used if the "rows" parameter is omitted, and in the case of the "start" parameter it makes the 0-or-1 question go away.
> The newly added {{CommonParamsTest}} methods are to ensure accidental (or intentional) changes to the (default) constants are caught by a test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org