You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2021/03/10 03:02:23 UTC
[GitHub] [phoenix] stoty commented on pull request #1160: Implement TableMetricsManager class and its associated functions for select. upsert and Delete Queries
stoty commented on pull request #1160:
URL: https://github.com/apache/phoenix/pull/1160#issuecomment-794787697
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| +0 :ok: | reexec | 4m 20s | Docker mode activated. |
||| _ Prechecks _ |
| +1 :green_heart: | dupname | 0m 0s | No case conflicting files found. |
| +1 :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. |
| +1 :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. |
| +1 :green_heart: | test4tests | 0m 0s | The patch appears to include 2 new or modified test files. |
||| _ 4.x Compile Tests _ |
| +1 :green_heart: | mvninstall | 14m 17s | 4.x passed |
| +1 :green_heart: | compile | 1m 0s | 4.x passed |
| +1 :green_heart: | checkstyle | 0m 57s | 4.x passed |
| +1 :green_heart: | javadoc | 0m 45s | 4.x passed |
| +0 :ok: | spotbugs | 3m 1s | phoenix-core in 4.x has 944 extant spotbugs warnings. |
||| _ Patch Compile Tests _ |
| +1 :green_heart: | mvninstall | 5m 39s | the patch passed |
| +1 :green_heart: | compile | 1m 0s | the patch passed |
| +1 :green_heart: | javac | 1m 0s | the patch passed |
| -1 :x: | checkstyle | 1m 7s | phoenix-core: The patch generated 349 new + 1274 unchanged - 1 fixed = 1623 total (was 1275) |
| -1 :x: | whitespace | 0m 0s | The patch 1 line(s) with tabs. |
| +1 :green_heart: | javadoc | 0m 46s | the patch passed |
| -1 :x: | spotbugs | 3m 16s | phoenix-core generated 8 new + 944 unchanged - 0 fixed = 952 total (was 944) |
||| _ Other Tests _ |
| +1 :green_heart: | unit | 185m 55s | phoenix-core in the patch passed. |
| -1 :x: | asflicense | 0m 12s | The patch generated 1 ASF License warnings. |
| | | 223m 18s | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:phoenix-core |
| | Write to static field org.apache.phoenix.monitoring.JmxMetricProvider.metricRegistry from instance method org.apache.phoenix.monitoring.JmxMetricProvider.registerMetricProvider() At JmxMetricProvider.java:from instance method org.apache.phoenix.monitoring.JmxMetricProvider.registerMetricProvider() At JmxMetricProvider.java:[line 33] |
| | Possible doublecheck on org.apache.phoenix.monitoring.TableMetricsManager.tableMetricsManager in org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:org.apache.phoenix.monitoring.TableMetricsManager.getInstance() At TableMetricsManager.java:[lines 92-94] |
| | org.apache.phoenix.monitoring.TableMetricsManager.tableMetricsManager should be package protected At TableMetricsManager.java: At TableMetricsManager.java:[line 53] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.options from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 58] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isMetricPublisherEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 75] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.isTableLevelMetricsEnabled from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 59] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableClientMetricsMapping from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 66] |
| | Write to static field org.apache.phoenix.monitoring.TableMetricsManager.tableMetricsManager from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:from instance method new org.apache.phoenix.monitoring.TableMetricsManager(QueryServicesOptions) At TableMetricsManager.java:[line 63] |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | ClientAPI=1.41 ServerAPI=1.41 base: https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1160/1/artifact/yetus-general-check/output/Dockerfile |
| GITHUB PR | https://github.com/apache/phoenix/pull/1160 |
| Optional Tests | dupname asflicense javac javadoc unit spotbugs hbaseanti checkstyle compile |
| uname | Linux 45ba7a2ad13f 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | dev/phoenix-personality.sh |
| git revision | 4.x / aee3f83 |
| Default Java | Private Build-1.8.0_242-8u242-b08-0ubuntu3~16.04-b08 |
| checkstyle | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1160/1/artifact/yetus-general-check/output/diff-checkstyle-phoenix-core.txt |
| whitespace | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1160/1/artifact/yetus-general-check/output/whitespace-tabs.txt |
| spotbugs | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1160/1/artifact/yetus-general-check/output/new-spotbugs-phoenix-core.html |
| Test Results | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1160/1/testReport/ |
| asflicense | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1160/1/artifact/yetus-general-check/output/patch-asflicense-problems.txt |
| Max. process+thread count | 5399 (vs. ulimit of 30000) |
| modules | C: phoenix-core U: phoenix-core |
| Console output | https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1160/1/console |
| versions | git=2.7.4 maven=3.3.9 spotbugs=4.1.3 |
| Powered by | Apache Yetus 0.12.0 https://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org