You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2020/12/04 08:58:07 UTC

[GitHub] [incubator-dolphinscheduler] dailidong commented on a change in pull request #4150: [Fix-4143][jar upgrade]upgrade quartz version to 2.3.0

dailidong commented on a change in pull request #4150:
URL: https://github.com/apache/incubator-dolphinscheduler/pull/4150#discussion_r535938198



##########
File path: dolphinscheduler-dist/release-docs/LICENSE
##########
@@ -445,6 +445,8 @@ The text of each license is also included at licenses/LICENSE-[project].txt.
     oshi-core 3.5.0: https://mvnrepository.com/artifact/com.github.oshi/oshi-core/3.5.0, EPL 1.0
     junit 4.12: https://mvnrepository.com/artifact/junit/junit/4.12, EPL 1.0
     h2-1.4.200 https://github.com/h2database/h2database/blob/master/LICENSE.txt, MPL 2.0 or EPL 1.0
+    mchange-commons-java 0.2.11: https://mvnrepository.com/artifact/com.mchange/mchange-commons-java/0.2.11, EPL 1.0
+    c3p0 0.9.5.2: https://mvnrepository.com/artifact/com.mchange/c3p0/0.9.5.2, EPL 1.0

Review comment:
       > hi, this is relatively difficult because Quartz relies on it. Type B licenses can also be introduced, but we need to be relatively cautious. What do you think?
   
   I think we don't use directly that can be removed , take c3po as an example, we don't use c3p0, we use Druid as database connection pool,  so I think it could be removed, but I'm not sure, just try?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org