You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "ARTISnetDev (via GitHub)" <gi...@apache.org> on 2025/08/28 14:09:28 UTC

[I] PB with sql metrics in dataset [superset]

ARTISnetDev opened a new issue, #34886:
URL: https://github.com/apache/superset/issues/34886

   ### Bug description
   
   Since v5.0.0, if we have add currency suffix in the sql metrics on a dataset. We can't modify this dataset after.
   
   ### Screenshots/recordings
   
   Error message :
   <img width="401" height="902" alt="Image" src="https://github.com/user-attachments/assets/158ebf38-989f-487e-bd46-df7e449b9a70" />
   Content on the metadata for the metrics : 
   <img width="1038" height="672" alt="Image" src="https://github.com/user-attachments/assets/f6a9c6e4-b4ab-4549-ae48-2dcee3601c8e" />
   
   After set to null the currency column. we can modify the dataset again
   
   ### Superset version
   
   5.0.0
   
   ### Python version
   
   3.11
   
   ### Node version
   
   I don't know
   
   ### Browser
   
   Not applicable
   
   ### Additional context
   
   _No response_
   
   ### Checklist
   
   - [ ] I have searched Superset docs and Slack and didn't find a solution to my problem.
   - [x] I have searched the GitHub issue tracker and didn't find a similar bug report.
   - [ ] I have checked Superset's logs for errors and if I found a relevant Python stacktrace, I included it here as text in the "additional context" section.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] PB with sql metrics in dataset [superset]

Posted by "ARTISnetDev (via GitHub)" <gi...@apache.org>.
ARTISnetDev commented on issue #34886:
URL: https://github.com/apache/superset/issues/34886#issuecomment-3234420370

   i m not sure because is not in the case that the metric is added with already exists message. It is in the case we defined the currency for each amount. In v4.X.X it worked. It is in the case we change other thing example synchronise the columns (because new one) and save 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] PB with sql metrics in dataset [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #34886: PB with sql metrics in dataset
URL: https://github.com/apache/superset/issues/34886


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] PB with sql metrics in dataset [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #34886:
URL: https://github.com/apache/superset/issues/34886#issuecomment-3234282062

   The bot is right! I'll close this, unless the workaround isn't working. Feel free to test the 6.0 release candidate as well! :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] PB with sql metrics in dataset [superset]

Posted by "dosubot[bot] (via GitHub)" <gi...@apache.org>.
dosubot[bot] commented on issue #34886:
URL: https://github.com/apache/superset/issues/34886#issuecomment-3233677119

   <!-- Answer -->
   This is a known bug in Superset 5.0.0 caused by a migration that changed the `currency` field for SQL metrics from a string to a JSON object, along with stricter backend validation. If the `currency` field contains a legacy string or an improperly formatted value, you'll get a validation error like "Length must be between 1 and 128" and won't be able to modify the dataset. Setting the `currency` field to `null` works because it bypasses the new validation rules, letting you edit the dataset again.
   
   A fix for this issue has already been merged and will be included in an upcoming release (5.0.1, 5.1.0, or 6.0.0). Until then, the only workaround is to remove or nullify the affected metric's currency field before making changes to the dataset. More details and confirmation of the fix are available in [this GitHub issue](https://github.com/apache/superset/issues/33964) and [the merged pull request](https://github.com/apache/superset/pull/33523).
   
   
   <!-- Dosu Comment Footer -->
   *To reply, just mention [@dosu](https://go.dosu.dev/dosubot).*
   
   ---
   <sup>How did I do? [Good](https://app.dosu.dev/response-feedback/ec91602e-680f-4888-944f-851ad9ad0567?feedback_type=great_response) | [Irrelevant](https://app.dosu.dev/response-feedback/ec91602e-680f-4888-944f-851ad9ad0567?feedback_type=irrelevant_answer) | [Incorrect](https://app.dosu.dev/response-feedback/ec91602e-680f-4888-944f-851ad9ad0567?feedback_type=incorrect_sources) | [Verbose](https://app.dosu.dev/response-feedback/ec91602e-680f-4888-944f-851ad9ad0567?feedback_type=too_verbose) | [Hallucination](https://app.dosu.dev/response-feedback/ec91602e-680f-4888-944f-851ad9ad0567?feedback_type=hallucination) | [Report 🐛](https://app.dosu.dev/response-feedback/ec91602e-680f-4888-944f-851ad9ad0567?feedback_type=bug_report) | [Other](https://app.dosu.dev/response-feedback/ec91602e-680f-4888-944f-851ad9ad0567?feedback_type=other)</sup>&nbsp;&nbsp;[![Chat with Dosu](https://dosu.dev/dosu-chat-badge.svg)](https://app.dosu.dev/a28d3c7e-a9d3-459e-9fb6-3a6f9ff4f357/ask?utm_source=githu
 b)&nbsp;[![Join Discord](https://img.shields.io/badge/join-5865F2?logo=discord&logoColor=white&label=)](https://go.dosu.dev/discord-bot)&nbsp;[![Share on X](https://img.shields.io/badge/X-share-black)](https://twitter.com/intent/tweet?text=%40dosu_ai%20helped%20me%20solve%20this%20issue!&url=https%3A//github.com/apache/superset/issues/34886)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] PB with sql metrics in dataset [superset]

Posted by "sadpandajoe (via GitHub)" <gi...@apache.org>.
sadpandajoe commented on issue #34886:
URL: https://github.com/apache/superset/issues/34886#issuecomment-3329879145

   Looking at the linked ticket, it looks like it may be resolved in 6.0rc1 already


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

Re: [I] PB with sql metrics in dataset [superset]

Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #34886:
URL: https://github.com/apache/superset/issues/34886#issuecomment-4748273535

   This appears to be addressed by a fix that landed in 6.0rc1. Closing for now — if you can still reproduce the dataset-edit error with currency-formatted SQL metrics on a current 6.x release, please comment with steps and we'll reopen.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org