You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sedona.apache.org by GitBox <gi...@apache.org> on 2022/06/30 19:57:14 UTC

[GitHub] [incubator-sedona] jiayuasu opened a new pull request, #639: [SEDONA-39] Fix lon/lat order in ST_Transform to be consistent with PostGIS

jiayuasu opened a new pull request, #639:
URL: https://github.com/apache/incubator-sedona/pull/639

   
   ## Did you read the Contributor Guide?
   
   - Yes, I have read [Contributor Rules](https://sedona.apache.org/community/rule/) and [Contributor Development Guide](https://sedona.apache.org/community/develop/)
   
   ## Is this PR related to a JIRA ticket?
   
   - Yes, the URL of the assoicated JIRA ticket is https://issues.apache.org/jira/browse/SEDONA-39. The PR name follows the format `[SEDONA-39] my subject`.
   
   
   ## What changes were proposed in this PR?
   
   
   ## How was this patch tested?
   
   
   ## Did this PR include necessary documentation updates?
   
   - Yes, I am adding a new API. I am using the [current SNAPSHOT version number](https://github.com/apache/incubator-sedona/blob/master/pom.xml#L29) in since `vX.Y.Z` format.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [sedona] jiayuasu closed pull request #639: [SEDONA-39] Fix lon/lat order in ST_Transform to be consistent with PostGIS

Posted by "jiayuasu (via GitHub)" <gi...@apache.org>.
jiayuasu closed pull request #639: [SEDONA-39] Fix lon/lat order in ST_Transform to be consistent with PostGIS
URL: https://github.com/apache/sedona/pull/639


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] Imbruced commented on pull request #639: [SEDONA-39] Fix lon/lat order in ST_Transform to be consistent with PostGIS

Posted by GitBox <gi...@apache.org>.
Imbruced commented on PR #639:
URL: https://github.com/apache/incubator-sedona/pull/639#issuecomment-1173054074

   I agree with @netanel246 we should be consistent with what Postgis does. And definitely we need communicate that clearly with users.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] jiayuasu commented on pull request #639: [SEDONA-39] Fix lon/lat order in ST_Transform to be consistent with PostGIS

Posted by GitBox <gi...@apache.org>.
jiayuasu commented on PR #639:
URL: https://github.com/apache/incubator-sedona/pull/639#issuecomment-1173159232

   @netanel246 @Imbruced Got it. I will then continue working on this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] jiayuasu commented on pull request #639: [SEDONA-39] Fix lon/lat order in ST_Transform to be consistent with PostGIS

Posted by GitBox <gi...@apache.org>.
jiayuasu commented on PR #639:
URL: https://github.com/apache/incubator-sedona/pull/639#issuecomment-1171630923

   @netanel246 @Imbruced @yitao-li 
   
   Since Sedona 1.0.0, ST_Transform uses lat/lon order, instead of lon/lat order in GeoSpark. So now Sedona behavior is different from what PostGIS does.
   
   Currently, who uses lon/lat order can (1) use ST_FlipCoordinates twice, before and after ST_Transform. or (2)`System.setProperty("org.geotools.referencing.forceXY", "true");`
   
   Do you think it is good to change back to lon/lat in this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-sedona] netanel246 commented on pull request #639: [SEDONA-39] Fix lon/lat order in ST_Transform to be consistent with PostGIS

Posted by GitBox <gi...@apache.org>.
netanel246 commented on PR #639:
URL: https://github.com/apache/incubator-sedona/pull/639#issuecomment-1172953353

   Hi @jiayuasu ,
   I think we should be aligned with PostGIS. 
   However, we must be clear about staying with lat/lon order and **emphasize** that users need to update their code if they use this version.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sedona.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org