You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/07/14 13:56:50 UTC
[GitHub] [incubator-linkis] peacewong opened a new pull request, #2468: [WIP] Fix multiple bugs in version 1.2.0
peacewong opened a new pull request, #2468:
URL: https://github.com/apache/incubator-linkis/pull/2468
### What is the purpose of the change
1. fix ec log path separator bug
2. Modify ec task submission to be asynchronous
3. io client support orchestrator wait time out
4. Fix file name garbled problem
5. update ec cores default value to 1
6. linkis-storage - fix null data exception in exporting of excel
7. Optimize the undone task interface to query only one day's data by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone commented on a diff in pull request #2468: Fix multiple bugs in version 1.2.0
Posted by GitBox <gi...@apache.org>.
casionone commented on code in PR #2468:
URL: https://github.com/apache/incubator-linkis/pull/2468#discussion_r921779231
##########
linkis-commons/linkis-storage/src/main/scala/org/apache/linkis/storage/excel/StorageExcelWriter.scala:
##########
@@ -150,29 +150,29 @@ class StorageExcelWriter(val charset: String, val sheetName: String, val dateFor
private def setCellTypeValue(dataType: DataType, elem: Any, cell: SXSSFCell): Unit = {
if (null == elem) return
- dataType match {
- case StringType => cell.setCellValue(DataType.valueToString(elem))
- case TinyIntType => cell.setCellValue(elem.toString.toInt)
- case ShortIntType => cell.setCellValue(elem.toString.toInt)
- case IntType => cell.setCellValue(elem.toString.toInt)
- case LongType => cell.setCellValue(elem.toString.toLong)
- case BigIntType => cell.setCellValue(elem.toString.toLong)
- case FloatType => cell.setCellValue(elem.toString.toFloat)
- case DoubleType => cell.setCellValue(elem.toString.toDouble)
- case CharType => cell.setCellValue(DataType.valueToString(elem))
- case VarcharType => cell.setCellValue(DataType.valueToString(elem))
- case DateType => cell.setCellValue(getDate(elem))
- case TimestampType => cell.setCellValue(getDate(elem))
- case DecimalType => cell.setCellValue(DataType.valueToString(elem))
- case BigDecimalType => cell.setCellValue(DataType.valueToString(elem))
- case _ =>
- val value = DataType.valueToString(elem)
- cell.setCellValue(value)
- if (null != dataType) {
- logger.warn(s"Cannot find matched type for dataType : ${dataType.toString}, string value:${value}, value className : ${elem.getClass.getName}, will treat it as string.")
- } else {
- logger.warn(s"Invalid null dataType. Will treat value string : ${value}, value className : ${elem.getClass.getName} as string.")
- }
+ Utils.tryCatch {
+ dataType match {
+ case StringType => cell.setCellValue(DataType.valueToString(elem))
+ case TinyIntType => cell.setCellValue(elem.toString.toInt)
+ case ShortIntType => cell.setCellValue(elem.toString.toInt)
+ case IntType => cell.setCellValue(elem.toString.toInt)
+ case LongType => cell.setCellValue(elem.toString.toLong)
+ case BigIntType => cell.setCellValue(elem.toString.toLong)
+ case FloatType => cell.setCellValue(elem.toString.toFloat)
+ case DoubleType => cell.setCellValue(elem.toString.toDouble)
+ case CharType => cell.setCellValue(DataType.valueToString(elem))
+ case VarcharType => cell.setCellValue(DataType.valueToString(elem))
+ case DateType => cell.setCellValue(getDate(elem))
+ case TimestampType => cell.setCellValue(getDate(elem))
+ case DecimalType => cell.setCellValue(DataType.valueToString(elem))
+ case BigDecimalType => cell.setCellValue(DataType.valueToString(elem))
+ case _ =>
+ val value = DataType.valueToString(elem)
+ cell.setCellValue(value)
+ }
+ } {
+ case e: Exception =>
+ cell.setCellValue(valueToString(elem))
Review Comment:
keep the uniform style?
`DataType.valueToString(elem)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] casionone merged pull request #2468: Fix multiple bugs in version 1.2.0
Posted by GitBox <gi...@apache.org>.
casionone merged PR #2468:
URL: https://github.com/apache/incubator-linkis/pull/2468
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2468: [WIP] Fix multiple bugs in version 1.2.0
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2468:
URL: https://github.com/apache/incubator-linkis/pull/2468#issuecomment-1184511681
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2468?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2468](https://codecov.io/gh/apache/incubator-linkis/pull/2468?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (00f6e66) into [dev-1.2.0](https://codecov.io/gh/apache/incubator-linkis/commit/7ab847aa124e0dffe780472402a30ad52bf95c0e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7ab847a) will **increase** coverage by `0.03%`.
> The diff coverage is `55.55%`.
```diff
@@ Coverage Diff @@
## dev-1.2.0 #2468 +/- ##
===============================================
+ Coverage 16.59% 16.63% +0.03%
- Complexity 1103 1104 +1
===============================================
Files 636 636
Lines 19520 19529 +9
Branches 2769 2770 +1
===============================================
+ Hits 3240 3248 +8
- Misses 15843 15844 +1
Partials 437 437
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/2468?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...linkis/jobhistory/restful/api/QueryRestfulApi.java](https://codecov.io/gh/apache/incubator-linkis/pull/2468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLXB1YmxpY3NlcnZpY2UvbGlua2lzLWpvYmhpc3Rvcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpbmtpcy9qb2JoaXN0b3J5L3Jlc3RmdWwvYXBpL1F1ZXJ5UmVzdGZ1bEFwaS5qYXZh) | `41.44% <0.00%> (-0.77%)` | :arrow_down: |
| [...obhistory/cache/impl/DefaultQueryCacheManager.java](https://codecov.io/gh/apache/incubator-linkis/pull/2468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLXB1YmxpYy1lbmhhbmNlbWVudHMvbGlua2lzLXB1YmxpY3NlcnZpY2UvbGlua2lzLWpvYmhpc3Rvcnkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpbmtpcy9qb2JoaXN0b3J5L2NhY2hlL2ltcGwvRGVmYXVsdFF1ZXJ5Q2FjaGVNYW5hZ2VyLmphdmE=) | `66.36% <71.42%> (+5.19%)` | :arrow_up: |
| [...apache/linkis/scheduler/queue/LoopArrayQueue.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2468/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXNjaGVkdWxlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9zY2hlZHVsZXIvcXVldWUvTG9vcEFycmF5UXVldWUuc2NhbGE=) | `32.07% <0.00%> (-1.89%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2468?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2468?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [7ab847a...00f6e66](https://codecov.io/gh/apache/incubator-linkis/pull/2468?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org