[GitHub] [pinot] yuanbenson commented on a diff in pull request #10303: Add excludeReplacedSegments param into table metadata API

["yuanbenson (via GitHub)" <gi...@apache.org>]

yuanbenson commented on code in PR #10303:
URL: https://github.com/apache/pinot/pull/10303#discussion_r1113518075


##########
pinot-common/src/main/java/org/apache/pinot/common/lineage/SegmentLineageUtils.java:
##########
@@ -53,4 +54,19 @@ public static void filterSegmentsBasedOnLineageInPlace(Set<String> segments, Seg
       }
     }
   }
+
+  public static Set<String> getDuplicateSegmentsToFilterOut(SegmentLineage segmentLineage) {

Review Comment:
   Yes, good point. Replaced segments don't necessarily mean duplicates, made this over-simplification while implementing by mistake :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org