You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Purshotam Shah <pu...@yahoo-inc.com> on 2013/11/25 22:51:06 UTC
Review Request 15848: [OOZIE-1627]Rerun doesn't resolve workflow app name
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15848/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1627
https://issues.apache.org/jira/browse/OOZIE-1627
Repository: oozie
Description
-------
Rerun doesn't resolve workflow app name
Diffs
-----
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1545406
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1545406
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/rerun-el-wf.xml 1545406
Diff: https://reviews.apache.org/r/15848/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 15848: [OOZIE-1627]Rerun doesn't resolve workflow app name
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15848/#review29398
-----------------------------------------------------------
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java
<https://reviews.apache.org/r/15848/#comment56612>
minor comment..can we remove this one from here and have it above this if block, so we call the resolve fn only once irrespective of whether sla is enabled or not.
- Virag Kothari
On Nov. 25, 2013, 9:51 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15848/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2013, 9:51 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1627
> https://issues.apache.org/jira/browse/OOZIE-1627
>
>
> Repository: oozie
>
>
> Description
> -------
>
> Rerun doesn't resolve workflow app name
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1545406
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1545406
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/rerun-el-wf.xml 1545406
>
> Diff: https://reviews.apache.org/r/15848/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 15848: [OOZIE-1627]Rerun doesn't resolve workflow app name
Posted by Virag Kothari <vi...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15848/#review29399
-----------------------------------------------------------
Ship it!
+1
- Virag Kothari
On Nov. 25, 2013, 10:06 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15848/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2013, 10:06 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1627
> https://issues.apache.org/jira/browse/OOZIE-1627
>
>
> Repository: oozie
>
>
> Description
> -------
>
> Rerun doesn't resolve workflow app name
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1545406
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1545406
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/rerun-el-wf.xml 1545406
>
> Diff: https://reviews.apache.org/r/15848/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>
Re: Review Request 15848: [OOZIE-1627]Rerun doesn't resolve workflow app name
Posted by Purshotam Shah <pu...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15848/
-----------------------------------------------------------
(Updated Nov. 25, 2013, 10:06 p.m.)
Review request for oozie.
Changes
-------
review comment.
Bugs: OOZIE-1627
https://issues.apache.org/jira/browse/OOZIE-1627
Repository: oozie
Description
-------
Rerun doesn't resolve workflow app name
Diffs (updated)
-----
http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1545406
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1545406
http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/rerun-el-wf.xml 1545406
Diff: https://reviews.apache.org/r/15848/diff/
Testing
-------
Thanks,
Purshotam Shah
Re: Review Request 15848: [OOZIE-1627]Rerun doesn't resolve workflow app name
Posted by Rohini Palaniswamy <ro...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15848/#review29397
-----------------------------------------------------------
Ship it!
Ship It!
- Rohini Palaniswamy
On Nov. 25, 2013, 9:51 p.m., Purshotam Shah wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15848/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2013, 9:51 p.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1627
> https://issues.apache.org/jira/browse/OOZIE-1627
>
>
> Repository: oozie
>
>
> Description
> -------
>
> Rerun doesn't resolve workflow app name
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1545406
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java 1545406
> http://svn.apache.org/repos/asf/oozie/trunk/core/src/test/resources/rerun-el-wf.xml 1545406
>
> Diff: https://reviews.apache.org/r/15848/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Purshotam Shah
>
>