You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Tony Zhu (Jira)" <ji...@apache.org> on 2022/09/15 05:39:00 UTC

[jira] [Comment Edited] (FLINK-28902) FileSystemJobResultStoreTestInternal is a unit test that's not following the unit test naming convents

    [ https://issues.apache.org/jira/browse/FLINK-28902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605120#comment-17605120 ] 

Tony Zhu edited comment on FLINK-28902 at 9/15/22 5:38 AM:
-----------------------------------------------------------

I created this PR [[FLINK-28902][tests] rename FileSystemJobResultStoreTestInternal to FileSystemJobResultStoreTest and add Internal to test methods part by tonyzhu918 · Pull Request #20839 · apache/flink (github.com)|https://github.com/apache/flink/pull/20839]. Could you help review please


was (Author: JIRAUSER295709):
I created this PR. Could you help review please

> FileSystemJobResultStoreTestInternal is a unit test that's not following the unit test naming convents
> ------------------------------------------------------------------------------------------------------
>
>                 Key: FLINK-28902
>                 URL: https://issues.apache.org/jira/browse/FLINK-28902
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Coordination, Test Infrastructure
>    Affects Versions: 1.15.1, 1.16.0
>            Reporter: Matthias Pohl
>            Assignee: Tony Zhu
>            Priority: Minor
>              Labels: pull-request-available, starter
>
> AzureCI still picks the test up as part of {{mvn verify}} (see an [example build|https://dev.azure.com/apache-flink/apache-flink/_build/results?buildId=39780&view=logs&j=0da23115-68bb-5dcd-192c-bd4c8adebde1&t=24c3384f-1bcb-57b3-224f-51bf973bbee8&l=8539]).
> Anyway, we should move the {{Internal}} suffix and move it somewhere inside of the test name.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)