[GitHub] [beam] shehzaadn-vd commented on a change in pull request #11154: [BEAM-1819] Key should be available in @OnTimer methods

[GitBox <gi...@apache.org>]

shehzaadn-vd commented on a change in pull request #11154: [BEAM-1819] Key should be available in @OnTimer methods
URL: https://github.com/apache/beam/pull/11154#discussion_r402698024
 
 

 ##########
 File path: examples/java/src/main/java/org/apache/beam/examples/complete/AutoComplete.java
 ##########
 @@ -386,7 +385,8 @@ public FormatForDatastore(String kind, String ancestorKey) {
     @ProcessElement
     public void processElement(ProcessContext c) {
       Entity.Builder entityBuilder = Entity.newBuilder();
-      Key key = makeKey(makeKey(kind, ancestorKey).build(), kind, c.element().getKey()).build();
+      com.google.datastore.v1.Key key =
+          makeKey(makeKey(kind, ancestorKey).build(), kind, c.element().getKey()).build();
 
 
 Review comment:
   the changes in this file don't seem necessary. We've got rid of an import but introduced a fully qualified class name instead.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services