You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/02/27 06:35:49 UTC
[GitHub] [pulsar] tuhaihe opened a new pull request #14478: Add books to Resources page
tuhaihe opened a new pull request #14478:
URL: https://github.com/apache/pulsar/pull/14478
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
### Motivation
Many books on Apache Pulsar have been published, so I would love to add the book resource to the website to help community members to learn Apache Pulsar.
### Modifications
Add books resources to the webpage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] urfreespace commented on a change in pull request #14478: [website] Add books to Resources page
Posted by GitBox <gi...@apache.org>.
urfreespace commented on a change in pull request #14478:
URL: https://github.com/apache/pulsar/pull/14478#discussion_r816516389
##########
File path: site2/website/data/resources.js
##########
@@ -1,4 +1,26 @@
module.exports = {
+ books: [
+ {
+ book: 'Apache Pulsar in Action',
+ author: "David Kjerrumgaard",
+ link: 'https://www.manning.com/books/apache-pulsar-in-action/'
+ },
+ {
+ book: 'Mastering Apache Pulsar',
+ author: "Jowanza Joseph",
+ link: 'https://www.oreilly.com/library/view/mastering-apache-pulsar/9781492084891/'
+ },
+ {
+ book: 'Cloud-Native Microservices with Apache Pulsar',
+ author: "Rahul Sharma, Mohammad Atyab",
+ link: 'https://link.springer.com/book/10.1007/978-1-4842-7839-0'
+ },
+ {
+ book: '深入解析 Apache Pulsar（Chinese Book, which means "Deep Dive into Apache Pulsar")',
+ author: "Lin Lin",
+ link: 'https://www.phei.com.cn/module/goods/wssd_content.jsp?bookid=59310'
+ }
+ ]
Review comment:
@tuhaihe Missing a comma here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] github-actions[bot] commented on pull request #14478: Add books to Resources page
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #14478:
URL: https://github.com/apache/pulsar/pull/14478#issuecomment-1053236442
@tuhaihe:Thanks for your contribution. For this PR, do we need to update docs?
(The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #14478: [website] Add books to Resources page
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #14478:
URL: https://github.com/apache/pulsar/pull/14478#issuecomment-1053852657
@tuhaihe thanks for your contribution!
1. Have you run a local preview before submitting changes? If so, can you please provide screenshots of your changes in the PR description? So that others know your changes clearly.
Steps of running a local preview: https://github.com/apache/pulsar/tree/master/site2#website
3. You delete the backticks (``) so that Bot can not recognize the info and then labels the PR with `doc-info-missing`.
[x] `doc-required` ✅
[x] doc-required ❌
Instrctions of doc labels: https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0/edit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on a change in pull request #14478: [website] Add books to Resources page
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on a change in pull request #14478:
URL: https://github.com/apache/pulsar/pull/14478#discussion_r815560331
##########
File path: site2/website/data/resources.js
##########
@@ -1,4 +1,26 @@
module.exports = {
+ books: [
+ {
+ book: 'Apache Pulsar in Action',
+ author: "David Kjerrumgaard",
+ link: 'https://www.manning.com/books/apache-pulsar-in-action/'
+ },
+ {
+ book: 'Mastering Apache Pulsar',
+ author: "Jowanza Joseph",
+ link: 'https://www.oreilly.com/library/view/mastering-apache-pulsar/9781492084891/'
+ },
+ {
+ book: 'Cloud-Native Microservices with Apache Pulsar',
+ author: "Rahul Sharma, Mohammad Atyab",
+ link: 'https://link.springer.com/book/10.1007/978-1-4842-7839-0'
+ },
+ {
+ book: '深入解析 Apache Pulsar（Chinese Book)',
Review comment:
```suggestion
book: '深入解析 Apache Pulsar (Chinese Book, which means "Deep Dive into Apache Pulsar")',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tuhaihe commented on pull request #14478: [website] Add books to Resources page
Posted by GitBox <gi...@apache.org>.
tuhaihe commented on pull request #14478:
URL: https://github.com/apache/pulsar/pull/14478#issuecomment-1055150628
Hi @Anonymitaet @urfreespace Thanks for your guys's help. I update this PR and run it successfully in local. This is the screenshot. PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #14478: [website] Add books to Resources page
Posted by GitBox <gi...@apache.org>.
codelipenghui merged pull request #14478:
URL: https://github.com/apache/pulsar/pull/14478
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org