You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2022/02/15 19:24:24 UTC
[kudu-CR](branch-1.16.x) [common] fix a bug in Schema::Reset(cols, ...)
Hello Yingchun Lai, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/18236
to review the following change.
Change subject: [common] fix a bug in Schema::Reset(cols, ...)
......................................................................
[common] fix a bug in Schema::Reset(cols, ...)
Prior to this patch, Schema::col_offsets_ was not cleared
upon calling Schema::Reset(). This patch addresses the issue.
A new test scenario is added to cover the corresponding regressions in future.
Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Reviewed-on: http://gerrit.cloudera.org:8080/18213
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 426d2ecb04d0f76ac50fe0868f40398ba6848582)
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
2 files changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/36/18236/1
--
To view, visit http://gerrit.cloudera.org:8080/18236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18236
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR](branch-1.16.x) [common] fix a bug in Schema::Reset(cols, ...)
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18236 )
Change subject: [common] fix a bug in Schema::Reset(cols, ...)
......................................................................
[common] fix a bug in Schema::Reset(cols, ...)
Prior to this patch, Schema::col_offsets_ was not cleared
upon calling Schema::Reset(). This patch addresses the issue.
A new test scenario is added to cover the corresponding regressions in future.
Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Reviewed-on: http://gerrit.cloudera.org:8080/18213
Tested-by: Kudu Jenkins
Reviewed-by: Yingchun Lai <ac...@gmail.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
(cherry picked from commit 426d2ecb04d0f76ac50fe0868f40398ba6848582)
Reviewed-on: http://gerrit.cloudera.org:8080/18236
Reviewed-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/common/schema-test.cc
M src/kudu/common/schema.cc
2 files changed, 13 insertions(+), 0 deletions(-)
Approvals:
Kudu Jenkins: Verified
Attila Bukor: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/18236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18236
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
[kudu-CR](branch-1.16.x) [common] fix a bug in Schema::Reset(cols, ...)
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18236 )
Change subject: [common] fix a bug in Schema::Reset(cols, ...)
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18236
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.16.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a197638cbfb568d5df605ed88f0bb95926ac722
Gerrit-Change-Number: 18236
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <ac...@gmail.com>
Gerrit-Reviewer: Yuqi Du <sh...@gmail.com>
Gerrit-Comment-Date: Wed, 16 Feb 2022 13:21:27 +0000
Gerrit-HasComments: No