You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Ilya Pronin <ip...@twopensource.com> on 2017/10/03 23:16:23 UTC

Re: Review Request 62286: Added CatchupMissing log process.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62286/
-----------------------------------------------------------

(Updated Oct. 4, 2017, 12:16 a.m.)


Review request for mesos and Jie Yu.


Changes
-------

Addressed review comments.


Summary (updated)
-----------------

Added CatchupMissing log process.


Bugs: MESOS-7973
    https://issues.apache.org/jira/browse/MESOS-7973


Repository: mesos


Description (updated)
-------

The process is used to catch-up a non-leading VOTING replica by running
the recovery protocol to find current begin and end positions of the log
and catching-up positions that are missing on the replica. This allows
following replicas to serve eventually consistent reads.


Diffs (updated)
-----

  src/log/catchup.hpp 123bc7a57e5e89f9ba75c36ba0cbe5ead807c518 
  src/log/catchup.cpp 94e1b00db2cd9d5a2368a979c1fd155bb6cac1f2 
  src/tests/log_tests.cpp f9f9400c901152779ae0ebfe74cf8f7aac1d3396 


Diff: https://reviews.apache.org/r/62286/diff/2/

Changes: https://reviews.apache.org/r/62286/diff/1-2/


Testing
-------

Added tests that verify that the new recovery process correctly performs and produces meaningful result under various circumstances (recovered positions were truncated, replica was lagging far behind). Ran `make check`.


Thanks,

Ilya Pronin

Re: Review Request 62286: Added CatchupMissing log process.

Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62286/#review194370
-----------------------------------------------------------


Ship it!




Ship It!

- Jie Yu


On Oct. 3, 2017, 11:16 p.m., Ilya Pronin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62286/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2017, 11:16 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-7973
>     https://issues.apache.org/jira/browse/MESOS-7973
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The process is used to catch-up a non-leading VOTING replica by running
> the recovery protocol to find current begin and end positions of the log
> and catching-up positions that are missing on the replica. This allows
> following replicas to serve eventually consistent reads.
> 
> 
> Diffs
> -----
> 
>   src/log/catchup.hpp 123bc7a57e5e89f9ba75c36ba0cbe5ead807c518 
>   src/log/catchup.cpp 94e1b00db2cd9d5a2368a979c1fd155bb6cac1f2 
>   src/tests/log_tests.cpp f9f9400c901152779ae0ebfe74cf8f7aac1d3396 
> 
> 
> Diff: https://reviews.apache.org/r/62286/diff/2/
> 
> 
> Testing
> -------
> 
> Added tests that verify that the new recovery process correctly performs and produces meaningful result under various circumstances (recovered positions were truncated, replica was lagging far behind). Ran `make check`.
> 
> 
> Thanks,
> 
> Ilya Pronin
> 
>