You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by ebarboni <gi...@git.apache.org> on 2017/10/13 22:34:57 UTC

[GitHub] incubator-netbeans pull request #144: Use InputSource to parse xml avoid enc...

GitHub user ebarboni opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/144

    Use InputSource to parse xml avoid encoding issue

    Attempt to fix build due to encoding issue in #70 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ebarboni/incubator-netbeans ratissue

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/144.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #144
    
----
commit 560c85307630f032768ee14b2c9ca84d0aac789b
Author: Eric Barboni <sk...@apache.org>
Date:   2017-10-13T22:28:34Z

    Use InputSource to parse xml avoid encoding issue

----


---

[GitHub] incubator-netbeans issue #144: Use InputSource to parse xml avoid encoding i...

Posted by JaroslavTulach <gi...@git.apache.org>.

Github user JaroslavTulach commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/144
  
    I used: `curl https://github.com/apache/incubator-netbeans/pull/144.patch | git am` to apply the patch. Let see if it helps.
    
    In general XML shall contain its encoding inside of its `<?xml encoding/>` header, so I am surprised the change should help. But let us see.


---