You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "menghaoranss (via GitHub)" <gi...@apache.org> on 2026/07/01 09:18:07 UTC

[PR] Rename AUTO to DATABASE for MetadataIdentifierCaseSensitivity [shardingsphere]

menghaoranss opened a new pull request, #38975:
URL: https://github.com/apache/shardingsphere/pull/38975

   
   Changes proposed in this pull request:
     - Rename AUTO to DATABASE for MetadataIdentifierCaseSensitivity
   
   ---
   
   Before committing this PR, I'm sure that I have checked the following options:
   - [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
   - [ ] I have self-reviewed the commit code.
   - [ ] I have (or in comment I request) added corresponding labels for the pull request.
   - [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
   - [ ] I have made corresponding changes to the documentation.
   - [ ] I have added corresponding unit tests for my changes.
   - [ ] I have updated the Release Notes of the current development version. For more details, see [Update Release Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Rename AUTO to DATABASE for MetadataIdentifierCaseSensitivity [shardingsphere]

Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss merged PR #38975:
URL: https://github.com/apache/shardingsphere/pull/38975


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Rename AUTO to DATABASE for MetadataIdentifierCaseSensitivity [shardingsphere]

Posted by "menghaoranss (via GitHub)" <gi...@apache.org>.
menghaoranss commented on PR #38975:
URL: https://github.com/apache/shardingsphere/pull/38975#issuecomment-4853552344

   
   ### Correction
   
   Previous Finding: I previously treated the removal of `AUTO` / `SENSITIVE` as a compatibility blocker.
   
   Current Status: Withdrawn.
   
   Reason: This configuration has not been released yet, so the enum values are not a released user-facing compatibility contract. Removing `SENSITIVE` is also consistent with the intended scope because forced case-sensitive metadata lookup is not a supported requirement.
   
   ### Summary
   
   **Review Result: Mergeable**
   
   Reason: This is a Code Correctness Review. The PR consistently narrows the unreleased `metadata-identifier-case-sensitivity` option to the intended supported values, renames the database-driven mode from `AUTO` to `DATABASE`, and updates the runtime default plus related tests/baselines. CI not reviewed by request.
   
   ### Evidence
   
   - `ConfigurationPropertyKey` now defaults `metadata-identifier-case-sensitivity` to `MetadataIdentifierCaseSensitivity.DATABASE`.
   - `MetadataIdentifierCaseSensitivity` now exposes only the intended values: `DATABASE` and `INSENSITIVE`.
   - `IdentifierCaseRuleResolver` keeps `INSENSITIVE` as the explicit override and otherwise delegates to database-specific rule providers, which matches the new `DATABASE` meaning.
   - Related tests and the RAL expected dataset were updated to match the new default value.
   
   ### Review Details
   
   - Review Focus: Code Correctness Review. CI not reviewed by request.
   - Reviewed Scope: latest PR head `981b364be61f4f3f1337f455ab86f0793982f601`; PR base `7b4abce1a2d5e78bbbeb4f5a0f39f0a29afb7437`; local merge-base `a4a7d8603410e213de6fd8652e9d1b6530077748`. The local triple-dot file list matched GitHub `/pulls/38975/files`.
   - Not Reviewed Scope: GitHub Actions/check-runs and workflow logs were not reviewed.
   - Verification: Reviewed PR metadata, commits, comments, reviews, file list, and local diff. No local Maven verification was run for this correction.
   - Release Note / User Docs: Not required for compatibility because the option has not been released yet; docs sync can be handled before the feature is released.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org