You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@isis.apache.org by Nacho Cánovas Rejón <n....@gesconsultor.com> on 2015/07/17 11:25:24 UTC

Feedback - ISIS-1171: if missing, default datanucleus.schema.autoCreateAll to false, not true (to avoid accidental modification of a target database).

Hi.

Some point out I found.

When we update to a version after  "ISIS-1171" commit, and we executed 
any junit test, it seems to be an infinite loop, so never ends the 
executed test.

This is the log test writes:
/
//11:13:31,331 [ServicesInstallerFromConfigurationAndAnnotation 
main       INFO ]  installing 
org.apache.isis.core.runtime.services.ServicesInstallerFromConfigurationAndAnnotation//
//11:13:31,842  [Reflections          main       INFO ] Reflections took 
318 ms to scan 4 urls, producing 164 keys and 874 values //
//11:13:32,186  [IsisSystemFixturesHookAbstract main INFO ]  
initialising Isis System//
//11:13:32,186  [IsisSystemFixturesHookAbstract main INFO ]  working 
directory: C:\workspace\xms-isis\xms\framework\architecture\integtests\.//
//11:13:32,186  [IsisSystemFixturesHookAbstract main INFO ]  resource 
stream source: null//
//11:14:45,974  [DataNucleusPersistenceMechanismInstaller main       
INFO ]  did *not* find JNDI datasource; will use JDBC//
//11:15:01,681  [Reflections          main       INFO ] Reflections took 
15702 ms to scan 10 urls, producing 222 keys and 2467 values //
//11:15:15,803  [MetaData             main       WARN ] Clase 
"com.xms.framework.architecture.domain.model.technology.extensions.node.LogicalNode" 
es abstracto pero tiene un valor de disriminador. No se va a usar el 
valor nunca!//
//11:15:15,803  [MetaData             main       WARN ] Clase 
"com.xms.framework.architecture.domain.model.technology.extensions.node.LogicalNode" 
es abstracto pero tiene un valor de disriminador. No se va a usar el 
valor nunca!//
//11:15:19,017  [MetaData             main       WARN ] Clase 
"com.xms.framework.architecture.domain.model.business.BusinessCollaboration" 
es abstracto pero tiene un valor de disriminador. No se va a usar el 
valor nunca!//
//11:15:19,017  [MetaData             main       WARN ] Clase 
"com.xms.framework.architecture.domain.model.business.BusinessCollaboration" 
es abstracto pero tiene un valor de disriminador. No se va a usar el 
valor nunca!//
//11:15:20,102  [MetaData             main       WARN ] Clase 
"com.xms.framework.architecture.domain.model.motivation.Stakeholder" es 
abstracto pero tiene un valor de disriminador. No se va a usar el valor 
nunca!//
//11:15:20,102  [MetaData             main       WARN ] Clase 
"com.xms.framework.architecture.domain.model.motivation.Stakeholder" es 
abstracto pero tiene un valor de disriminador. No se va a usar el valor 
nunca!//
//11:15:24,217  [Persistence          main       WARN ] Field 
com.xms.framework.metadata.domain.model.OneToOneSpecificationChoice.oneToOneSpecification 
represents either a 1-1 relation, or a N-1 relation where the other end 
uses "subclass-table" inheritance strategy and more than 1 subclasses 
with a table. This is not fully supported//
//11:15:24,217  [Persistence          main       WARN ] Field 
com.xms.framework.metadata.domain.model.OneToOneSpecificationChoice.oneToOneSpecification 
represents either a 1-1 relation, or a N-1 relation where the other end 
uses "subclass-table" inheritance strategy and more than 1 subclasses 
with a table. This is not fully supported//
//11:15:26,485  [Reflections          main       INFO ] Reflections took 
648 ms to scan 10 urls, producing 222 keys and 2467 values //
//11:15:26,489  [EmailServiceDefault  main       WARN ]  NOT configured/


I took a look into this feature and I add 
"isis.persistor.datanucleus.impl.datanucleus.schema.autoCreateAll" to 
"true" and all work fine, so I only pointing out this problem to let you 
know.

This is the log I see when test runs fine.

/11:13:31,331 [ServicesInstallerFromConfigurationAndAnnotation 
main       INFO ]  installing 
org.apache.isis.core.runtime.services.ServicesInstallerFromConfigurationAndAnnotation//
//11:13:31,842  [Reflections          main       INFO ] Reflections took 
318 ms to scan 4 urls, producing 164 keys and 874 values //
//11:13:32,186  [IsisSystemFixturesHookAbstract main INFO ]  
initialising Isis System//
//11:13:32,186  [IsisSystemFixturesHookAbstract main INFO ]  working 
directory: C:\workspace\xms-isis\xms\framework\architecture\integtests\.//
//11:13:32,186  [IsisSystemFixturesHookAbstract main INFO ]  resource 
stream source: null//
//11:14:45,974  [DataNucleusPersistenceMechanismInstaller main       
INFO ]  did *not* find JNDI datasource; will use JDBC//
//11:15:01,681  [Reflections          main       INFO ] Reflections took 
15702 ms to scan 10 urls, producing 222 keys and 2467 values //
//11:15:15,803  [MetaData             main       WARN ] Clase 
"com.xms.framework.architecture.domain.model.technology.extensions.node.LogicalNode" 
es abstracto pero tiene un valor de disriminador. No se va a usar el 
valor nunca!//
//11:15:15,803  [MetaData             main       WARN ] Clase 
"com.xms.framework.architecture.domain.model.technology.extensions.node.LogicalNode" 
es abstracto pero tiene un valor de disriminador. No se va a usar el 
valor nunca!//
//11:15:19,017  [MetaData             main       WARN ] Clase 
"com.xms.framework.architecture.domain.model.business.BusinessCollaboration" 
es abstracto pero tiene un valor de disriminador. No se va a usar el 
valor nunca!//
//11:15:19,017  [MetaData             main       WARN ] Clase 
"com.xms.framework.architecture.domain.model.business.BusinessCollaboration" 
es abstracto pero tiene un valor de disriminador. No se va a usar el 
valor nunca!//
//11:15:20,102  [MetaData             main       WARN ] Clase 
"com.xms.framework.architecture.domain.model.motivation.Stakeholder" es 
abstracto pero tiene un valor de disriminador. No se va a usar el valor 
nunca!//
//11:15:20,102  [MetaData             main       WARN ] Clase 
"com.xms.framework.architecture.domain.model.motivation.Stakeholder" es 
abstracto pero tiene un valor de disriminador. No se va a usar el valor 
nunca!//
//11:15:24,217  [Persistence          main       WARN ] Field 
com.xms.framework.metadata.domain.model.OneToOneSpecificationChoice.oneToOneSpecification 
represents either a 1-1 relation, or a N-1 relation where the other end 
uses "subclass-table" inheritance strategy and more than 1 subclasses 
with a table. This is not fully supported//
//11:15:24,217  [Persistence          main       WARN ] Field 
com.xms.framework.metadata.domain.model.OneToOneSpecificationChoice.oneToOneSpecification 
represents either a 1-1 relation, or a N-1 relation where the other end 
uses "subclass-table" inheritance strategy and more than 1 subclasses 
with a table. This is not fully supported//
//11:15:26,485  [Reflections          main       INFO ] Reflections took 
648 ms to scan 10 urls, producing 222 keys and 2467 values //
//11:15:26,489  [EmailServiceDefault  main       WARN ]  NOT configured/
11:15:31,653  [IsisSystemFixturesHookAbstract Thread-1   INFO ]  
shutting down system
11:15:31,788  [IsisContext          Thread-1   INFO ]  closing all instances
11:15:31,788  [ObjectReflectorDefault Thread-1   INFO ]  shutting down 
org.apache.isis.core.metamodel.specloader.ObjectReflectorDefault@3f3e10bc

Best regards.

-- 
Ignacio Cánovas Rejón
Tel. 902 900 231
Fax  96 353 19 09
n.canovas@gesconsultor.com
www.gesconsultor.com

Este mensaje y los ficheros anexos son confidenciales. Los mismos contienen información reservada que no puede ser difundida. Si usted ha recibido este correo por error, tenga la amabilidad de eliminarlo de su sistema y avisar al remitente mediante reenvío a su dirección electrónica; no deberá copiar el mensaje ni divulgar su contenido a ninguna persona.

Su dirección de correo electrónico junto a sus datos personales constan en un fichero titularidad de GESDATOS SOFTWARE S.L. cuya finalidad es la de mantener el contacto con Ud. Si quiere saber de qué información disponemos de Ud., modificarla, y en su caso, cancelarla, puede hacerlo enviando un escrito al efecto, acompañado de una fotocopia de su D.N.I. a la siguiente dirección: GESDATOS SOFTWARE S.L. Av. Cortes Valencianas 50-1º-C, C.P.  46015 de Valencia. Asimismo, es su responsabilidad comprobar que este mensaje o sus archivos adjuntos no contengan virus informáticos, y en caso que los tuvieran eliminarlos.



---
El software de antivirus Avast ha analizado este correo electrónico en busca de virus.
http://www.avast.com

Re: Feedback - ISIS-1171: if missing, default datanucleus.schema.autoCreateAll to false, not true (to avoid accidental modification of a target database).

Posted by Dan Haywood <da...@haywood-associates.co.uk>.
Just to comment on this, Nacho.

I don't think the code was going into an infinite loop; more likely that
each and every test was failing to bootstrap the app, and producing very
similar stack traces that (unless you looked very closely) probably gave
the appearance of an infinite loop.

If that property is set to false for integ tests an running against
hsql:mem (or other in-memory database), then I would indeed expect it to
fail.

The default configuration for integration tests does specify this parameter
to be "true" [1] (as you said you set up alsoy), so I think there's nothing
to be fixed here...  just a "migration issue" from one version of the
framework to the next.

Thanks for the feedback, though.

Cheers
Dan

[1]
https://github.com/apache/isis/blob/ec058a8deace942ea555fa6cc1f7bea23dfa8009/core/runtime/src/main/java/org/apache/isis/objectstore/jdo/datanucleus/IsisConfigurationForJdoIntegTests.java#L72



On 17 July 2015 at 10:25, Nacho Cánovas Rejón <n....@gesconsultor.com>
wrote:

> Hi.
>
> Some point out I found.
>
> When we update to a version after  "ISIS-1171" commit, and we executed any
> junit test, it seems to be an infinite loop, so never ends the executed
> test.
>
> This is the log test writes:
> /
> //11:13:31,331 [ServicesInstallerFromConfigurationAndAnnotation main
>  INFO ]  installing
> org.apache.isis.core.runtime.services.ServicesInstallerFromConfigurationAndAnnotation//
> //11:13:31,842  [Reflections          main       INFO ] Reflections took
> 318 ms to scan 4 urls, producing 164 keys and 874 values //
> //11:13:32,186  [IsisSystemFixturesHookAbstract main INFO ]  initialising
> Isis System//
> //11:13:32,186  [IsisSystemFixturesHookAbstract main INFO ]  working
> directory: C:\workspace\xms-isis\xms\framework\architecture\integtests\.//
> //11:13:32,186  [IsisSystemFixturesHookAbstract main INFO ]  resource
> stream source: null//
> //11:14:45,974  [DataNucleusPersistenceMechanismInstaller main       INFO
> ]  did *not* find JNDI datasource; will use JDBC//
> //11:15:01,681  [Reflections          main       INFO ] Reflections took
> 15702 ms to scan 10 urls, producing 222 keys and 2467 values //
> //11:15:15,803  [MetaData             main       WARN ] Clase
> "com.xms.framework.architecture.domain.model.technology.extensions.node.LogicalNode"
> es abstracto pero tiene un valor de disriminador. No se va a usar el valor
> nunca!//
> //11:15:15,803  [MetaData             main       WARN ] Clase
> "com.xms.framework.architecture.domain.model.technology.extensions.node.LogicalNode"
> es abstracto pero tiene un valor de disriminador. No se va a usar el valor
> nunca!//
> //11:15:19,017  [MetaData             main       WARN ] Clase
> "com.xms.framework.architecture.domain.model.business.BusinessCollaboration"
> es abstracto pero tiene un valor de disriminador. No se va a usar el valor
> nunca!//
> //11:15:19,017  [MetaData             main       WARN ] Clase
> "com.xms.framework.architecture.domain.model.business.BusinessCollaboration"
> es abstracto pero tiene un valor de disriminador. No se va a usar el valor
> nunca!//
> //11:15:20,102  [MetaData             main       WARN ] Clase
> "com.xms.framework.architecture.domain.model.motivation.Stakeholder" es
> abstracto pero tiene un valor de disriminador. No se va a usar el valor
> nunca!//
> //11:15:20,102  [MetaData             main       WARN ] Clase
> "com.xms.framework.architecture.domain.model.motivation.Stakeholder" es
> abstracto pero tiene un valor de disriminador. No se va a usar el valor
> nunca!//
> //11:15:24,217  [Persistence          main       WARN ] Field
> com.xms.framework.metadata.domain.model.OneToOneSpecificationChoice.oneToOneSpecification
> represents either a 1-1 relation, or a N-1 relation where the other end
> uses "subclass-table" inheritance strategy and more than 1 subclasses with
> a table. This is not fully supported//
> //11:15:24,217  [Persistence          main       WARN ] Field
> com.xms.framework.metadata.domain.model.OneToOneSpecificationChoice.oneToOneSpecification
> represents either a 1-1 relation, or a N-1 relation where the other end
> uses "subclass-table" inheritance strategy and more than 1 subclasses with
> a table. This is not fully supported//
> //11:15:26,485  [Reflections          main       INFO ] Reflections took
> 648 ms to scan 10 urls, producing 222 keys and 2467 values //
> //11:15:26,489  [EmailServiceDefault  main       WARN ]  NOT configured/
>
>
> I took a look into this feature and I add
> "isis.persistor.datanucleus.impl.datanucleus.schema.autoCreateAll" to
> "true" and all work fine, so I only pointing out this problem to let you
> know.
>
> This is the log I see when test runs fine.
>
> /11:13:31,331 [ServicesInstallerFromConfigurationAndAnnotation main
>  INFO ]  installing
> org.apache.isis.core.runtime.services.ServicesInstallerFromConfigurationAndAnnotation//
> //11:13:31,842  [Reflections          main       INFO ] Reflections took
> 318 ms to scan 4 urls, producing 164 keys and 874 values //
> //11:13:32,186  [IsisSystemFixturesHookAbstract main INFO ]  initialising
> Isis System//
> //11:13:32,186  [IsisSystemFixturesHookAbstract main INFO ]  working
> directory: C:\workspace\xms-isis\xms\framework\architecture\integtests\.//
> //11:13:32,186  [IsisSystemFixturesHookAbstract main INFO ]  resource
> stream source: null//
> //11:14:45,974  [DataNucleusPersistenceMechanismInstaller main       INFO
> ]  did *not* find JNDI datasource; will use JDBC//
> //11:15:01,681  [Reflections          main       INFO ] Reflections took
> 15702 ms to scan 10 urls, producing 222 keys and 2467 values //
> //11:15:15,803  [MetaData             main       WARN ] Clase
> "com.xms.framework.architecture.domain.model.technology.extensions.node.LogicalNode"
> es abstracto pero tiene un valor de disriminador. No se va a usar el valor
> nunca!//
> //11:15:15,803  [MetaData             main       WARN ] Clase
> "com.xms.framework.architecture.domain.model.technology.extensions.node.LogicalNode"
> es abstracto pero tiene un valor de disriminador. No se va a usar el valor
> nunca!//
> //11:15:19,017  [MetaData             main       WARN ] Clase
> "com.xms.framework.architecture.domain.model.business.BusinessCollaboration"
> es abstracto pero tiene un valor de disriminador. No se va a usar el valor
> nunca!//
> //11:15:19,017  [MetaData             main       WARN ] Clase
> "com.xms.framework.architecture.domain.model.business.BusinessCollaboration"
> es abstracto pero tiene un valor de disriminador. No se va a usar el valor
> nunca!//
> //11:15:20,102  [MetaData             main       WARN ] Clase
> "com.xms.framework.architecture.domain.model.motivation.Stakeholder" es
> abstracto pero tiene un valor de disriminador. No se va a usar el valor
> nunca!//
> //11:15:20,102  [MetaData             main       WARN ] Clase
> "com.xms.framework.architecture.domain.model.motivation.Stakeholder" es
> abstracto pero tiene un valor de disriminador. No se va a usar el valor
> nunca!//
> //11:15:24,217  [Persistence          main       WARN ] Field
> com.xms.framework.metadata.domain.model.OneToOneSpecificationChoice.oneToOneSpecification
> represents either a 1-1 relation, or a N-1 relation where the other end
> uses "subclass-table" inheritance strategy and more than 1 subclasses with
> a table. This is not fully supported//
> //11:15:24,217  [Persistence          main       WARN ] Field
> com.xms.framework.metadata.domain.model.OneToOneSpecificationChoice.oneToOneSpecification
> represents either a 1-1 relation, or a N-1 relation where the other end
> uses "subclass-table" inheritance strategy and more than 1 subclasses with
> a table. This is not fully supported//
> //11:15:26,485  [Reflections          main       INFO ] Reflections took
> 648 ms to scan 10 urls, producing 222 keys and 2467 values //
> //11:15:26,489  [EmailServiceDefault  main       WARN ]  NOT configured/
> 11:15:31,653  [IsisSystemFixturesHookAbstract Thread-1   INFO ]  shutting
> down system
> 11:15:31,788  [IsisContext          Thread-1   INFO ]  closing all
> instances
> 11:15:31,788  [ObjectReflectorDefault Thread-1   INFO ]  shutting down
> org.apache.isis.core.metamodel.specloader.ObjectReflectorDefault@3f3e10bc
>
> Best regards.
>
> --
> Ignacio Cánovas Rejón
> Tel. 902 900 231
> Fax  96 353 19 09
> n.canovas@gesconsultor.com
> www.gesconsultor.com
>
> Este mensaje y los ficheros anexos son confidenciales. Los mismos
> contienen información reservada que no puede ser difundida. Si usted ha
> recibido este correo por error, tenga la amabilidad de eliminarlo de su
> sistema y avisar al remitente mediante reenvío a su dirección electrónica;
> no deberá copiar el mensaje ni divulgar su contenido a ninguna persona.
>
> Su dirección de correo electrónico junto a sus datos personales constan en
> un fichero titularidad de GESDATOS SOFTWARE S.L. cuya finalidad es la de
> mantener el contacto con Ud. Si quiere saber de qué información disponemos
> de Ud., modificarla, y en su caso, cancelarla, puede hacerlo enviando un
> escrito al efecto, acompañado de una fotocopia de su D.N.I. a la siguiente
> dirección: GESDATOS SOFTWARE S.L. Av. Cortes Valencianas 50-1º-C, C.P.
> 46015 de Valencia. Asimismo, es su responsabilidad comprobar que este
> mensaje o sus archivos adjuntos no contengan virus informáticos, y en caso
> que los tuvieran eliminarlos.
>
>
>
> ---
> El software de antivirus Avast ha analizado este correo electrónico en
> busca de virus.
> http://www.avast.com
>