[jira] [Commented] (TINKERPOP-2035) Gremlin-JavaScript: Pass custom headers to the websocket connection

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613443#comment-16613443 ] 

ASF GitHub Bot commented on TINKERPOP-2035:
-------------------------------------------

Github user jorgebay commented on the issue:

    https://github.com/apache/tinkerpop/pull/929
  
    Thanks for the patch @deejvince and thanks for filing TINKERPOP-2035 @beebs-systap !
    
    I think its a good idea to expose ways to set the request header, as it's part of the [protocol](https://tools.ietf.org/html/rfc6455). You will need the option to set the header on all GLVs (i.e., Python, C#, Java), right?


> Gremlin-JavaScript: Pass custom headers to the websocket connection
> -------------------------------------------------------------------
>
>                 Key: TINKERPOP-2035
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2035
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: javascript
>    Affects Versions: 3.3.3
>            Reporter: Brad Bebee
>            Priority: Major
>
> In some cases, it is required to pass extra header information to the Gremlin server to successfully make a connection. This ticket is to add the feature to enable users to optionally pass headers via the JavaScript client when connecting to a Gremlin Server.
> This was originally noted when connecting to Amazon Neptune with the SIGv4 signing required when using IAM-based authentication, but is generally applicable for use of the JavaScript client with Gremlin Servers that require additional header information. 
> The corresponding PR is below.
> [Pull Request|https://github.com/apache/tinkerpop/pull/929]



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)