You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "DavidLiu (Jira)" <ji...@apache.org> on 2022/07/22 05:14:00 UTC

[jira] [Comment Edited] (FLINK-27536) Rename method parameter in AsyncSinkWriter

    [ https://issues.apache.org/jira/browse/FLINK-27536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17569805#comment-17569805 ] 

DavidLiu edited comment on FLINK-27536 at 7/22/22 5:13 AM:
-----------------------------------------------------------

The pull request

[https://github.com/apache/flink/pull/20338]

Please help review it.

 


was (Author: JIRAUSER289843):
https://github.com/apache/flink/pull/20338

> Rename method parameter in AsyncSinkWriter
> ------------------------------------------
>
>                 Key: FLINK-27536
>                 URL: https://issues.apache.org/jira/browse/FLINK-27536
>             Project: Flink
>          Issue Type: Improvement
>          Components: Connectors / Common
>    Affects Versions: 1.15.0
>            Reporter: Zichen Liu
>            Assignee: DavidLiu
>            Priority: Minor
>              Labels: pull-request-available
>
> Change the abstract method's parameter naming in AsyncSinkWriter.
> From
>   Consumer<List<RequestEntryT>> requestResult
> to
>   Consumer<List<RequestEntryT>> requestToRetry
> or something similar.
>  
> This is because the consumer here is supposed to accept a list of requests that need to be retried.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)