You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/10 02:15:13 UTC
[GitHub] [rocketmq-operator] shendongsd opened a new pull request, #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard
shendongsd opened a new pull request, #132:
URL: https://github.com/apache/rocketmq-operator/pull/132
## What is the purpose of the change
【ISSUE [#73】support(https://github.com/apache/rocketmq-operator/issues/73) support mounting a configMap to rocketmq-dashboard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] shendongsd commented on a diff in pull request #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard
Posted by GitBox <gi...@apache.org>.
shendongsd commented on code in PR #132:
URL: https://github.com/apache/rocketmq-operator/pull/132#discussion_r995363419
##########
example/rocketmq_v1alpha1_console_cr.yaml:
##########
@@ -1,11 +1,47 @@
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: console-config
+data:
+ application.yml: |
+ server:
+ port: 8080
+ servlet:
+ encoding:
+ charset: UTF-8
+ enabled: true
+ force: true
+ spring:
+ application:
+ name: rocketmq-dashboard
+ logging:
+ config: classpath:logback.xml
+ rocketmq:
+ config:
+ namesrvAddrs:
+ - XXX:XXX
Review Comment:
The role-permission.yml can be added to configmap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] caigy commented on pull request #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard
Posted by "caigy (via GitHub)" <gi...@apache.org>.
caigy commented on PR #132:
URL: https://github.com/apache/rocketmq-operator/pull/132#issuecomment-1733671933
integrated in #182
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] drivebyer commented on pull request #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard
Posted by "drivebyer (via GitHub)" <gi...@apache.org>.
drivebyer commented on PR #132:
URL: https://github.com/apache/rocketmq-operator/pull/132#issuecomment-1722967635
This pr is not respond for a longtime, so I open another pr to implement it, see: https://github.com/apache/rocketmq-operator/pull/181
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] caigy commented on a diff in pull request #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard
Posted by GitBox <gi...@apache.org>.
caigy commented on code in PR #132:
URL: https://github.com/apache/rocketmq-operator/pull/132#discussion_r995294581
##########
example/rocketmq_v1alpha1_console_cr.yaml:
##########
@@ -1,11 +1,47 @@
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: console-config
+data:
+ application.yml: |
+ server:
+ port: 8080
+ servlet:
+ encoding:
+ charset: UTF-8
+ enabled: true
+ force: true
+ spring:
+ application:
+ name: rocketmq-dashboard
+ logging:
+ config: classpath:logback.xml
+ rocketmq:
+ config:
+ namesrvAddrs:
+ - XXX:XXX
Review Comment:
@shendongsd Should we also define `role-permission.yml` in config map?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] zongtanghu commented on pull request #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard
Posted by GitBox <gi...@apache.org>.
zongtanghu commented on PR #132:
URL: https://github.com/apache/rocketmq-operator/pull/132#issuecomment-1280148054
Please, put forward your commit codes for optimizing codes as soon as possible!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] caigy commented on a diff in pull request #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard
Posted by GitBox <gi...@apache.org>.
caigy commented on code in PR #132:
URL: https://github.com/apache/rocketmq-operator/pull/132#discussion_r996552283
##########
example/rocketmq_v1alpha1_console_cr.yaml:
##########
@@ -1,11 +1,47 @@
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: console-config
+data:
+ application.yml: |
+ server:
+ port: 8080
+ servlet:
+ encoding:
+ charset: UTF-8
+ enabled: true
+ force: true
+ spring:
+ application:
+ name: rocketmq-dashboard
+ logging:
+ config: classpath:logback.xml
+ rocketmq:
+ config:
+ namesrvAddrs:
+ - XXX:XXX
Review Comment:
@shendongsd Pls also add `role-permission.yml` to config map and reference it in `Console` CR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] zongtanghu commented on pull request #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard
Posted by GitBox <gi...@apache.org>.
zongtanghu commented on PR #132:
URL: https://github.com/apache/rocketmq-operator/pull/132#issuecomment-1278559539
Hi，please fix and optimize the codes according to other member's advices! @shendongsd
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] caigy commented on a diff in pull request #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard
Posted by GitBox <gi...@apache.org>.
caigy commented on code in PR #132:
URL: https://github.com/apache/rocketmq-operator/pull/132#discussion_r992922312
##########
example/rocketmq_v1alpha1_console_cr.yaml:
##########
@@ -1,11 +1,47 @@
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: console-config
+data:
+ application.yml: |
+ server:
+ port: 8080
+ servlet:
+ encoding:
+ charset: UTF-8
+ enabled: true
+ force: true
+ spring:
+ application:
+ name: rocketmq-dashboard
+ logging:
+ config: classpath:logback.xml
+ rocketmq:
+ config:
+ namesrvAddrs:
+ - XXX:XXX
Review Comment:
IMO nameserver address should be injected by rocketmq-operator, not manually configured.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] caigy closed pull request #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard
Posted by "caigy (via GitHub)" <gi...@apache.org>.
caigy closed pull request #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard
URL: https://github.com/apache/rocketmq-operator/pull/132
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] shendongsd commented on a diff in pull request #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard
Posted by GitBox <gi...@apache.org>.
shendongsd commented on code in PR #132:
URL: https://github.com/apache/rocketmq-operator/pull/132#discussion_r997087644
##########
example/rocketmq_v1alpha1_console_cr.yaml:
##########
@@ -1,11 +1,47 @@
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: console-config
+data:
+ application.yml: |
+ server:
+ port: 8080
+ servlet:
+ encoding:
+ charset: UTF-8
+ enabled: true
+ force: true
+ spring:
+ application:
+ name: rocketmq-dashboard
+ logging:
+ config: classpath:logback.xml
+ rocketmq:
+ config:
+ namesrvAddrs:
+ - XXX:XXX
Review Comment:
Ok，I could add it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] caigy commented on a diff in pull request #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard
Posted by GitBox <gi...@apache.org>.
caigy commented on code in PR #132:
URL: https://github.com/apache/rocketmq-operator/pull/132#discussion_r1003935691
##########
example/rocketmq_v1alpha1_console_cr.yaml:
##########
@@ -1,3 +1,57 @@
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: console-config
+data:
+ application.yml: |
+ server:
+ port: 8080
+ servlet:
+ encoding:
+ charset: UTF-8
+ enabled: true
+ force: true
+ spring:
+ application:
+ name: rocketmq-dashboard
+ logging:
+ config: classpath:logback.xml
+ rocketmq:
+ config:
+ isVIPChannel:
+ timeoutMillis:
+ dataPath: /tmp/rocketmq-console/data
+ enableDashBoardCollect: true
+ msgTrackTopicName:
+ ticketKey: ticket
+ loginRequired: false
+ useTLS: false
+ threadpool:
+ config:
+ coreSize: 10
+ maxSize: 10
+ keepAliveTime: 3000
+ queueSize: 5000
+ role-permission.yml: |+
Review Comment:
It seems that indentation is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-operator] shendongsd commented on a diff in pull request #132: 【ISSUE #73】support mounting a configMap to rocketmq-dashboard
Posted by GitBox <gi...@apache.org>.
shendongsd commented on code in PR #132:
URL: https://github.com/apache/rocketmq-operator/pull/132#discussion_r993163631
##########
example/rocketmq_v1alpha1_console_cr.yaml:
##########
@@ -1,11 +1,47 @@
+apiVersion: v1
+kind: ConfigMap
+metadata:
+ name: console-config
+data:
+ application.yml: |
+ server:
+ port: 8080
+ servlet:
+ encoding:
+ charset: UTF-8
+ enabled: true
+ force: true
+ spring:
+ application:
+ name: rocketmq-dashboard
+ logging:
+ config: classpath:logback.xml
+ rocketmq:
+ config:
+ namesrvAddrs:
+ - XXX:XXX
Review Comment:
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org