You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Gilbert Song <so...@gmail.com> on 2016/01/12 00:40:55 UTC
Re: Review Request 42058: Added test case for protobuf parse passing
error msg form nest JSON.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42058/
-----------------------------------------------------------
(Updated Jan. 11, 2016, 3:40 p.m.)
Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, Joseph Wu, and Timothy Chen.
Summary (updated)
-----------------
Added test case for protobuf parse passing error msg form nest JSON.
Bugs: MESOS-4311
https://issues.apache.org/jira/browse/MESOS-4311
Repository: mesos
Description (updated)
-------
Added test case for protobuf parse passing error msg form nest JSON.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp bf2a2b8a9f67c6a4cf66b156b9c14fae015a8af0
Diff: https://reviews.apache.org/r/42058/diff/
Testing
-------
make check (ubuntu14.04 + clang-3.6)
Because this patch depends on patch `41943`'s fix in `include/stout/protobuf.hpp`. To avoid compiling `protobuf_tests.proto` on different branches and merge them, this patch is implemented depending on `41943`. I did the following test:
1. Reverted any changes in `include/stout/protobuf.hpp`.
2. Tested the `ParseNestedJSONContainingJSONNull` test case -> failed (either not passing any nested error message or passing a wrong message).
3. Changed `include/stout/protobuf.hpp` on the part of passing nested error messages -> expected failures with correct error messaged showed.
4. Re-add the `include/stout/protobuf.hpp` fix from patch `41943` -> passed.
Thanks,
Gilbert Song
Re: Review Request 42058: Added test case for protobuf parse passing
error msg form nest JSON.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42058/#review113889
-----------------------------------------------------------
Ship it!
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp (line 391)
<https://reviews.apache.org/r/42058/#comment174672>
How about 'ParseJSONNestedError'?
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp (lines 393 - 395)
<https://reviews.apache.org/r/42058/#comment174674>
The following might be more succinct?
```
// Here we trigger an error parsing the 'nested' message.
```
3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp (line 405)
<https://reviews.apache.org/r/42058/#comment174673>
How about a comment to point out the error?
```
" \"str\": 1.0" // Error due to int for string type.
```
- Ben Mahler
On Jan. 11, 2016, 11:40 p.m., Gilbert Song wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42058/
> -----------------------------------------------------------
>
> (Updated Jan. 11, 2016, 11:40 p.m.)
>
>
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Jie Yu, Joris Van Remoortere, Joseph Wu, and Timothy Chen.
>
>
> Bugs: MESOS-4311
> https://issues.apache.org/jira/browse/MESOS-4311
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added test case for protobuf parse passing error msg form nest JSON.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/tests/protobuf_tests.cpp bf2a2b8a9f67c6a4cf66b156b9c14fae015a8af0
>
> Diff: https://reviews.apache.org/r/42058/diff/
>
>
> Testing
> -------
>
> make check (ubuntu14.04 + clang-3.6)
>
> Because this patch depends on patch `41943`'s fix in `include/stout/protobuf.hpp`. To avoid compiling `protobuf_tests.proto` on different branches and merge them, this patch is implemented depending on `41943`. I did the following test:
>
> 1. Reverted any changes in `include/stout/protobuf.hpp`.
> 2. Tested the `ParseNestedJSONContainingJSONNull` test case -> failed (either not passing any nested error message or passing a wrong message).
> 3. Changed `include/stout/protobuf.hpp` on the part of passing nested error messages -> expected failures with correct error messaged showed.
> 4. Re-add the `include/stout/protobuf.hpp` fix from patch `41943` -> passed.
>
>
> Thanks,
>
> Gilbert Song
>
>