You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "EdColeman (via GitHub)" <gi...@apache.org> on 2023/09/15 13:50:56 UTC

[GitHub] [accumulo] EdColeman commented on a diff in pull request #3745: Add Message Prefix for File deletion actions in GCRun

EdColeman commented on code in PR #3745:
URL: https://github.com/apache/accumulo/pull/3745#discussion_r1327318518


##########
server/gc/src/main/java/org/apache/accumulo/gc/GCRun.java:
##########
@@ -87,7 +87,9 @@
  * A single garbage collection performed on a table (Root, MD) or all User tables.
  */
 public class GCRun implements GarbageCollectionEnvironment {
+  // loggers are not static to support unique naming by level
   private final Logger log;
+  private static String fileActionPrefix = "FILE-ACTION:";

Review Comment:
   My opinion: having it makes it explicit and also easier to track down with a show usages if ever need.  And if it was me, making sure its `spelt` the same everywhere ;-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org