[GitHub] timifasubaa closed pull request #5432: Typo fixes in viz.py and CONTRIBUTING.md

[GitBox <gi...@apache.org>]

timifasubaa closed pull request #5432: Typo fixes in viz.py and CONTRIBUTING.md
URL: https://github.com/apache/incubator-superset/pull/5432
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 519644a4af..08547f0406 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -493,7 +493,7 @@ https://github.com/apache/incubator-superset/pull/3013
   In the future we'll start publishing release candidates for minor releases
   only, but typically not for micro release.
   The process will be similar to the process described above, expect the
-  tags will be formated `0.25.0rc1`, `0.25.0rc2`, ..., until consensus
+  tags will be formatted `0.25.0rc1`, `0.25.0rc2`, ..., until consensus
   is reached.
 
   We should also have a Github PR label process to target the proper
diff --git a/superset/viz.py b/superset/viz.py
index ef2e22fbcd..d1732fa755 100644
--- a/superset/viz.py
+++ b/superset/viz.py
@@ -86,7 +86,7 @@ def __init__(self, datasource, form_data, force=False):
         self.force = force
 
         # Keeping track of whether some data came from cache
-        # this is useful to trigerr the <CachedLabel /> when
+        # this is useful to trigger the <CachedLabel /> when
         # in the cases where visualization have many queries
         # (FilterBox for instance)
         self._some_from_cache = False
@@ -129,7 +129,7 @@ def handle_js_int_overflow(data):
         return data
 
     def run_extra_queries(self):
-        """Lyfecycle method to use when more than one query is needed
+        """Lifecycle method to use when more than one query is needed
 
         In rare-ish cases, a visualization may need to execute multiple
         queries. That is the case for FilterBox or for time comparison
@@ -156,7 +156,7 @@ def handle_nulls(self, df):
         df = df.fillna(fillna)
 
     def get_fillna_for_col(self, col):
-        """Returns the value for use as filler for a specific Column.type"""
+        """Returns the value to use as filler for a specific Column.type"""
         if col:
             if col.is_string:
                 return ' NULL'
@@ -323,7 +323,7 @@ def cache_key(self, query_obj):
 
         We remove datetime bounds that are hard values,
         and replace them with the use-provided inputs to bounds, which
-        may we time-relative (as in "5 days ago" or "now").
+        may be time-relative (as in "5 days ago" or "now").
         """
         cache_dict = copy.copy(query_obj)
 


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org