You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/09/08 04:33:43 UTC
[GitHub] [flink] Myasuka opened a new pull request #13349: [FLINK-18335] [tests] Add more debuging logs for NotifyCheckpointAbortedITCase
Myasuka opened a new pull request #13349:
URL: https://github.com/apache/flink/pull/13349
## What is the purpose of the change
Someone reported that NotifyCheckpointAbortedITCase is not stable in FLINK-18335. However, I cannot reproduce this problem locally and on my private CI.
Thus, as discussed in the ticket, we plan to increase the timeout and add more debuging logs.
## Brief change log
- Add more debuging logs for `NotifyCheckpointAbortedITCase`
## Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
This change added tests and can be verified as follows:
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13349: [FLINK-18335] [tests] Add more debuging logs for NotifyCheckpointAbortedITCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13349:
URL: https://github.com/apache/flink/pull/13349#issuecomment-688617994
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77c43f984f9a66201cf8b80b18ac94e836bc81ca",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6321",
"triggerID" : "77c43f984f9a66201cf8b80b18ac94e836bc81ca",
"triggerType" : "PUSH"
}, {
"hash" : "4db7db811ffca2e08eb534eda348476582a50a20",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6398",
"triggerID" : "4db7db811ffca2e08eb534eda348476582a50a20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77c43f984f9a66201cf8b80b18ac94e836bc81ca Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6321)
* 4db7db811ffca2e08eb534eda348476582a50a20 Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6398)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger merged pull request #13349: [FLINK-18335] [tests] Add more debuging logs for NotifyCheckpointAbortedITCase
Posted by GitBox <gi...@apache.org>.
rmetzger merged pull request #13349:
URL: https://github.com/apache/flink/pull/13349
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13349: [FLINK-18335] [tests] Add more debuging logs for NotifyCheckpointAbortedITCase
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13349:
URL: https://github.com/apache/flink/pull/13349#issuecomment-688613180
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 77c43f984f9a66201cf8b80b18ac94e836bc81ca (Tue Sep 08 04:36:37 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on pull request #13349: [FLINK-18335] [tests] Add more debuging logs for NotifyCheckpointAbortedITCase
Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #13349:
URL: https://github.com/apache/flink/pull/13349#issuecomment-692584684
Thanks a lot. Merging!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] Myasuka commented on a change in pull request #13349: [FLINK-18335] [tests] Add more debuging logs for NotifyCheckpointAbortedITCase
Posted by GitBox <gi...@apache.org>.
Myasuka commented on a change in pull request #13349:
URL: https://github.com/apache/flink/pull/13349#discussion_r485575933
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/NotifyCheckpointAbortedITCase.java
##########
@@ -97,8 +99,10 @@
*/
@RunWith(Parameterized.class)
public class NotifyCheckpointAbortedITCase extends TestLogger {
+ private static final Logger LOG = LoggerFactory.getLogger(NotifyCheckpointAbortedITCase.class);
Review comment:
Resolved in latest commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13349: [FLINK-18335] [tests] Add more debuging logs for NotifyCheckpointAbortedITCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13349:
URL: https://github.com/apache/flink/pull/13349#issuecomment-688617994
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77c43f984f9a66201cf8b80b18ac94e836bc81ca",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6321",
"triggerID" : "77c43f984f9a66201cf8b80b18ac94e836bc81ca",
"triggerType" : "PUSH"
}, {
"hash" : "4db7db811ffca2e08eb534eda348476582a50a20",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6398",
"triggerID" : "4db7db811ffca2e08eb534eda348476582a50a20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4db7db811ffca2e08eb534eda348476582a50a20 Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6398)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #13349: [FLINK-18335] [tests] Add more debuging logs for NotifyCheckpointAbortedITCase
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #13349:
URL: https://github.com/apache/flink/pull/13349#issuecomment-688617994
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77c43f984f9a66201cf8b80b18ac94e836bc81ca",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "77c43f984f9a66201cf8b80b18ac94e836bc81ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77c43f984f9a66201cf8b80b18ac94e836bc81ca UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] rmetzger commented on a change in pull request #13349: [FLINK-18335] [tests] Add more debuging logs for NotifyCheckpointAbortedITCase
Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #13349:
URL: https://github.com/apache/flink/pull/13349#discussion_r484676380
##########
File path: flink-tests/src/test/java/org/apache/flink/test/checkpointing/NotifyCheckpointAbortedITCase.java
##########
@@ -97,8 +99,10 @@
*/
@RunWith(Parameterized.class)
public class NotifyCheckpointAbortedITCase extends TestLogger {
+ private static final Logger LOG = LoggerFactory.getLogger(NotifyCheckpointAbortedITCase.class);
Review comment:
No need to add this logger. You can use the `log` instance from `TestLogger`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13349: [FLINK-18335] [tests] Add more debuging logs for NotifyCheckpointAbortedITCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13349:
URL: https://github.com/apache/flink/pull/13349#issuecomment-688617994
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77c43f984f9a66201cf8b80b18ac94e836bc81ca",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6321",
"triggerID" : "77c43f984f9a66201cf8b80b18ac94e836bc81ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77c43f984f9a66201cf8b80b18ac94e836bc81ca Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6321)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13349: [FLINK-18335] [tests] Add more debuging logs for NotifyCheckpointAbortedITCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13349:
URL: https://github.com/apache/flink/pull/13349#issuecomment-688617994
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77c43f984f9a66201cf8b80b18ac94e836bc81ca",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6321",
"triggerID" : "77c43f984f9a66201cf8b80b18ac94e836bc81ca",
"triggerType" : "PUSH"
}, {
"hash" : "4db7db811ffca2e08eb534eda348476582a50a20",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4db7db811ffca2e08eb534eda348476582a50a20",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77c43f984f9a66201cf8b80b18ac94e836bc81ca Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6321)
* 4db7db811ffca2e08eb534eda348476582a50a20 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #13349: [FLINK-18335] [tests] Add more debuging logs for NotifyCheckpointAbortedITCase
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #13349:
URL: https://github.com/apache/flink/pull/13349#issuecomment-688617994
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "77c43f984f9a66201cf8b80b18ac94e836bc81ca",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6321",
"triggerID" : "77c43f984f9a66201cf8b80b18ac94e836bc81ca",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 77c43f984f9a66201cf8b80b18ac94e836bc81ca Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=6321)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org