[GitHub] [pinot] pjfanning commented on a change in pull request #8158: [issue-8157] upgrade calcite due to cve

[GitBox <gi...@apache.org>]

pjfanning commented on a change in pull request #8158:
URL: https://github.com/apache/pinot/pull/8158#discussion_r805175198



##########
File path: pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java
##########
@@ -710,14 +711,18 @@ private static Expression compileFunctionExpression(SqlBasicCall functionNode) {
           compilePathExpression(functionName, functionNode, path);
           return RequestUtils.getIdentifierExpression(path.toString());
         }
+        if ((functionNode.getFunctionQuantifier() != null) && ("DISTINCT".equals(
+            functionNode.getFunctionQuantifier().toString()))) {
+          functionName = "DISTINCTCOUNT";

Review comment:
       there is a test - the change was made because the test started failing




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org