[GitHub] [zookeeper] eolivelli commented on a change in pull request #1170: ZOOKEEPER-3643: Testing and documenting secure and unsecure ZK client connections

[GitBox <gi...@apache.org>]

eolivelli commented on a change in pull request #1170: ZOOKEEPER-3643: Testing and documenting secure and unsecure ZK client connections
URL: https://github.com/apache/zookeeper/pull/1170#discussion_r365857473
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/ClientCnxn.java
 ##########
 @@ -1679,6 +1680,13 @@ States getState() {
         return state;
     }
 
+    /**
+     * Returns true if SSL connection was requested and the actual ClientCnxnSocket supports SSL
+     */
+    public boolean isSSL() {
 
 Review comment:
   I would go for 'isSecure'
   
   But honestly I don't see value in having this method.
   
   How will the application benefit from this API?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services