[GitHub] [cloudstack] nvazquez commented on a change in pull request #5848: Feat/add vdisk UUID to list volume

[GitBox <gi...@apache.org>]

nvazquez commented on a change in pull request #5848:
URL: https://github.com/apache/cloudstack/pull/5848#discussion_r835463712



##########
File path: engine/schema/src/main/resources/META-INF/db/schema-41610to41700.sql
##########
@@ -220,6 +220,19 @@ CREATE VIEW `cloud`.`service_offering_view` AS
     GROUP BY
         `service_offering`.`id`;
 
+
+DELIMITER //
+CREATE PROCEDURE create_external_uuid_in_volumes()
+  BEGIN
+    SELECT count(*) INTO @count FROM INFORMATION_SCHEMA.COLUMNS WHERE table_name = 'volumes' AND table_schema='cloud' AND column_name = 'external_uuid';
+    IF @count < 1 THEN ALTER TABLE cloud.volumes ADD COLUMN external_uuid VARCHAR(40) DEFAULT null;
+    END IF;
+  END //
+DELIMITER ;
+CALL create_external_uuid_in_volumes;
+DROP PROCEDURE create_external_uuid_in_volumes;

Review comment:
       How about this?
   
   ````
   DROP PROCEDURE IF EXISTS `cloud`.`create_external_uuid_in_volumes`();
   
   CREATE PROCEDURE `cloud`.`create_external_uuid_in_volumes`()
   BEGIN
           IF NOT EXISTS ((SELECT * FROM INFORMATION_SCHEMA.COLUMNS WHERE
               table_name = 'volumes' AND
               table_schema='cloud' AND
               column_name = 'external_uuid'))
           THEN
               ALTER TABLE cloud.volumes ADD COLUMN external_uuid VARCHAR(40) DEFAULT null;
               END IF; END;;
   
   CALL `cloud`.`create_external_uuid_in_volumes`();
   ````




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org