You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/03/03 00:15:44 UTC
[kudu-CR] test result server: better handling for non-ASCII in logs
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/9478
to review the following change.
Change subject: test_result_server: better handling for non-ASCII in logs
......................................................................
test_result_server: better handling for non-ASCII in logs
I was trying to diagnose a test failure whose log contained gdb stack
traces, and got this exception:
Traceback (most recent call last):
File "/home/todd/flaky-test-server-env/lib/python2.6/site-packages/cherrypy/_cprequest.py", line 670, in respond
response.body = self.handler()
File "/home/todd/flaky-test-server-env/lib/python2.6/site-packages/cherrypy/lib/encoding.py", line 217, in __call__
self.body = self.oldhandler(*args, **kwargs)
File "/home/todd/flaky-test-server-env/lib/python2.6/site-packages/cherrypy/_cpdispatch.py", line 61, in __call__
return self.callable(*self.args, **self.kwargs)
File "./test_result_server.py", line 174, in diagnose
return self.render_container(template.render(summary=summary, log_text=log_text))
File "/home/todd/flaky-test-server-env/li
b/python2.6/site-packages/jinja2/environment.py", line 969, in render
return self.environment.handle_exception(exc_info, True)
File "/home/todd/flaky-test-server-env/lib/python2.6/site-packages/jinja2/environment.py", line 742, in handle_exception
reraise(exc_type, exc_value, tb)
File "<template>", line 5, in top-level template code
UnicodeDecodeError: 'ascii' codec can't decode byte 0xd0 in position 3871577: ordinal not in range(128)
The docs for jinja2 say that it expects to receive unicode types, and I
think we're passing in strings. This should fix that.
Change-Id: Iac6da45ffe6c473dc985e60a4471ba708bae4610
---
M build-support/test_result_server.py
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/78/9478/1
--
To view, visit http://gerrit.cloudera.org:8080/9478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac6da45ffe6c473dc985e60a4471ba708bae4610
Gerrit-Change-Number: 9478
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] test result server: better handling for non-ASCII in logs
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has abandoned this change. ( http://gerrit.cloudera.org:8080/9478 )
Change subject: test_result_server: better handling for non-ASCII in logs
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/9478
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: Iac6da45ffe6c473dc985e60a4471ba708bae4610
Gerrit-Change-Number: 9478
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>