You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/11/26 19:34:21 UTC
[GitHub] [airflow] FloChehab opened a new pull request #12646: Fix chart jobs delete policy for improved idempotency
FloChehab opened a new pull request #12646:
URL: https://github.com/apache/airflow/pull/12646
Hello,
A pretty quick fix on the chart for something a bit annoying.
---
The chart has two jobs (migrate-database & create-user).
These jobs are run post-install and post-upgrade and only deleted on success.
So if for some reason (quick reinstall / upgrade), the job fails or is stuck then helm
will fail because the job already exists.
This commit sets the `helm.sh/hook-delete-policy` to `before-hook-creation,hook-succeeded`
so helm will always delete the jobs before creating them again.
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on pull request #12646: Fix chart jobs delete policy for improved idempotency
Posted by GitBox <gi...@apache.org>.
FloChehab commented on pull request #12646:
URL: https://github.com/apache/airflow/pull/12646#issuecomment-736593678
Hello @potiuk, I think you might be able to review this. It's a very quick PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab edited a comment on pull request #12646: Fix chart jobs delete policy for improved idempotency
Posted by GitBox <gi...@apache.org>.
FloChehab edited a comment on pull request #12646:
URL: https://github.com/apache/airflow/pull/12646#issuecomment-736593678
Hello @potiuk, I think you might be able to review this. It's a very quick/simple PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #12646: Fix chart jobs delete policy for improved idempotency
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #12646:
URL: https://github.com/apache/airflow/pull/12646
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] FloChehab commented on pull request #12646: Fix chart jobs delete policy for improved idempotency
Posted by GitBox <gi...@apache.org>.
FloChehab commented on pull request #12646:
URL: https://github.com/apache/airflow/pull/12646#issuecomment-736737572
Thanks !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org